-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feature: Python script and module to check dataset readiness for data preservation #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call Preserve.save_metadata() in preserve_checks
- Call Preserve.check_files() in preserve_checks
- Change summary_dict to list for JSON compatibility
- Docstrings update
- Call Preserve.make_symbolic_links() in preserve_checks
- Call Preserve.delete_hidden_files() in preserve_checks
astrochun
added
curation
Pertains to aspects of curation, including workflow management
enhancement
New feature or request
preservation
Related to data preservation
scripts
Script development
labels
Jul 9, 2021
- Call Preserve.delete_old_readme_files() in preserve_checks
- Include info message when not deleting files
- Note: This is an initial (not final) commit for the attempt! - Call Preserve.update_files() in preserve_checks
Preservation work is now in the ReBACH repo. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
curation
Pertains to aspects of curation, including workflow management
enhancement
New feature or request
preservation
Related to data preservation
scripts
Script development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is WIP. Do not merge!
This is a new feature to support preparation for preservation checks.
Closes #235
ToDo List
@astrochun:
As of 07/26/2021, here is the current status of this PR:
While most methods have been tested at a minimum level for the preservation check workflow, it is still not fully tested/explored. The methods of
Preserve
that have been tested include:get_metadata
,save_metadata
,check_files
,make_symbolic_links
,delete_old_readme_files
,delete_hidden_files
,delete_files
(used bydelete_hidden_files
).I have not tested:
Preserve.update_files
method--metadata_only
option should work for this purpose.In addition, we should have the script run as a "dry run" by default and to have a
--update
option. This will ensure that files are not replaced and to not download metadata. This would be a keyword input option that would need to be available to all method, probably through a (self
) instance variable inPreserve
.Test plan
Update Changelog
Resources
Screenshots or additional context