Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: README construction/update doesn't work without Deposit Agreement #222

Open
astrochun opened this issue Jun 10, 2021 · 0 comments
Open
Labels
api Use of a third-party API bug Something isn't working curation Pertains to aspects of curation, including workflow management p1 Issues affecting production, multiple users scripts Script development
Milestone

Comments

@astrochun
Copy link
Contributor

Describe the bug

Generally we will have a Deposit Agreement, but for testing I encountered the following. This is because the deposit does not have a Deposit Agreement.
As such it has no ResponseID and SurveyID. See below for traceback error.

Reproduction Steps

  1. Run get_data with a deposit that doesn't have a Deposit Agreement

Outputted Messages

Traceback (most recent call last):
  File "/Users/cly/codes/UALibraries/LD_Cool_P/ldcoolp/scripts/update_readme", line 100, in <module>
    rc = readme.ReadmeClass(dn, config_dict=config_dict, update=True, log=log)
  File "/Users/cly/codes/UALibraries/LD_Cool_P/ldcoolp/curation/inspection/readme/__init__.py", line 161, in __init__
    self.qualtrics_readme_dict = self.retrieve_qualtrics_readme()
  File "/Users/cly/codes/UALibraries/LD_Cool_P/ldcoolp/curation/inspection/readme/__init__.py", line 379, in retrieve_qualtrics_readme
    readme_dict = self.q.retrieve_qualtrics_readme(self.dn)
  File "/Users/cly/codes/UALibraries/LD_Cool_P/ldcoolp/curation/api/qualtrics.py", line 597, in retrieve_qualtrics_readme
    self.find_deposit_agreement(dn_dict)
  File "/Users/cly/codes/UALibraries/LD_Cool_P/ldcoolp/curation/api/qualtrics.py", line 314, in find_deposit_agreement
    raise ValueError
ValueError

Version information

Expected behavior

Much like the Qualtrics API, we prompt for ResponseID and SurveyID. A similar request should occur. This most likely requires a bit of refactoring.

Screenshots

Additional context

Implemented in: TBD

@astrochun astrochun added api Use of a third-party API bug Something isn't working curation Pertains to aspects of curation, including workflow management p1 Issues affecting production, multiple users scripts Script development labels Jun 10, 2021
@astrochun astrochun added this to the v1.2.0 milestone Jun 10, 2021
@astrochun astrochun self-assigned this Jun 10, 2021
@astrochun astrochun removed their assignment Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Use of a third-party API bug Something isn't working curation Pertains to aspects of curation, including workflow management p1 Issues affecting production, multiple users scripts Script development
Projects
None yet
Development

No branches or pull requests

1 participant