Keep a new tab's late focus from taking the caret away

Opening a tab (⌘⇧B) focuses its address bar twice: once when the tab becomes active, and again
in an animation frame that newTab queues for when the panel was not yet visible. Chromium can
hold frames back for an inactive or busy window. The late focus then landed after the person,
or a test, had already moved on, and took the caret out of the composer mid-typing.

That failed CI on #293: store-desktop.spec.ts's browser-tools recovery case filled the composer
just as the late frame ran. The text went into the address bar and the composer stayed empty
(job 117782462586). The same case failed on #294's first run.

The late focus now applies only if focus has not moved since the tab opened. The new
workspace.spec.ts case holds animation frames, moves to the composer, releases the frames and
types. It failed first: the composer lost focus when the frame ran.

Coven-Harness: Claude Code / claude-opus-5-5

Author: BunsDev

apps/desktop/e2e/workspace.spec.ts

@@ -182,6 +182,27 @@ test("a delayed browser snapshot cannot replace an address being edited", async
   await expect(input).toHaveValue("https://example.com/fast");
 });
 
+test("a new tab's late focus never takes the caret from where you started typing", async () => {
+  // Hold animation frames, as Chromium does for an inactive or busy window.
+  await page.evaluate(() => {
+    const w = window as unknown as { __frames: FrameRequestCallback[]; __raf: typeof requestAnimationFrame };
+    w.__frames = []; w.__raf = window.requestAnimationFrame;
+    window.requestAnimationFrame = (callback) => { w.__frames.push(callback); return w.__frames.length; };
+  });
+  await page.keyboard.press("Meta+Shift+b");
+  await expect(tid(page, "workspace-address")).toBeFocused();
+  await tid(page, "composer-input").focus();
+  await page.evaluate(() => {
+    const w = window as unknown as { __frames: FrameRequestCallback[]; __raf: typeof requestAnimationFrame };
+    window.requestAnimationFrame = w.__raf;
+    for (const callback of w.__frames.splice(0)) callback(performance.now());
+  });
+  await expect(tid(page, "composer-input")).toBeFocused();
+  await page.keyboard.type("Keep this draft");
+  await expect(tid(page, "composer-input")).toHaveValue("Keep this draft");
+  await expect(tid(page, "workspace-address")).toHaveValue("");
+});
+
 test("superseded navigation, overlays, guest shortcuts and window destruction preserve browser lifecycle", async () => {
   const { createServer } = await import("node:http");
   const server = createServer((req, res) => { if (req.url === "/slow") return; res.writeHead(200, { "Content-Type": "text/html" }); res.end("<title>Fast destination</title><h1>Ready</h1>"); });

apps/desktop/src/renderer/components/Workspace.tsx

@@ -54,7 +54,15 @@ export function Workspace({ thread, changes, onRefresh, onRevert, visible, onSho
     if (currentRef.current?.kind === "terminal") onHideTerminal();
     const tab = makeTab();
     setTabs((prev) => [...prev, tab]); setActive(tab.id); setFull(fullView); setAddMenu(false); setError(""); onShow();
-    requestAnimationFrame(() => addressRef.current?.focus());
+    // A frame can arrive late (an inactive or busy window). By then the address may already have focus,
+    // or the person may have moved on to type elsewhere: once focus has moved at all, leave it.
+    let moved = false;
+    const mark = () => { moved = true; };
+    document.addEventListener("focusin", mark, true);
+    requestAnimationFrame(() => {
+      document.removeEventListener("focusin", mark, true);
+      if (!moved) addressRef.current?.focus();
+    });
   }, [onShow, onHideTerminal]);
   const openTool = (kind: "review" | "files" | "terminal" | "canvas") => {
     const existing = tabs.find((tab) => tab.kind === kind);