fix: remove console log + add lint rule (#793)

Author: YousefED

.eslintrc.js

@@ -26,6 +26,7 @@ module.exports = {
   },
   ignorePatterns: ["**/ui/*"],
   rules: {
+    "no-console": "error",
     curly: 1,
     "import/no-extraneous-dependencies": [
       "error",

packages/core/src/editor/BlockNoteEditor.ts

@@ -307,6 +307,7 @@ export class BlockNoteEditor<
     this.resolveFileUrl = newOptions.resolveFileUrl || (async (url) => url);
 
     if (newOptions.collaboration && newOptions.initialContent) {
+      // eslint-disable-next-line no-console
       console.warn(
         "When using Collaboration, initialContent might cause conflicts, because changes should come from the collaboration provider"
       );
@@ -777,6 +778,7 @@ export class BlockNoteEditor<
     for (const mark of marks) {
       const config = this.schema.styleSchema[mark.type.name];
       if (!config) {
+        // eslint-disable-next-line no-console
         console.warn("mark not found in styleschema", mark.type.name);
         continue;
       }

packages/core/src/editor/BlockNoteTipTapEditor.ts

@@ -87,6 +87,7 @@ export class BlockNoteTipTapEditor extends TiptapEditor {
         this.options.parseOptions
       );
     } catch (e) {
+      // eslint-disable-next-line no-console
       console.error(
         "Error creating document from blocks passed as `initialContent`. Caused by exception: ",
         e

packages/dev-scripts/examples/gen.ts

@@ -51,6 +51,7 @@ async function writeTemplate(project: Project, templateFile: string) {
   // try {
   //   // fs.unlinkSync(targetFilePath);
   // } catch (e) {}
+  // eslint-disable-next-line no-console
   console.log("written", targetFilePath);
 }
 
@@ -79,6 +80,7 @@ async function generateExamplesData(projects: Project[]) {
 const projects = getExampleProjects();
 
 for (const project of projects) {
+  // eslint-disable-next-line no-console
   console.log("generating code for example", project);
   await generateCodeForExample(project);
 }

packages/react/src/components/FormattingToolbar/FormattingToolbarController.tsx

@@ -80,8 +80,8 @@ export const FormattingToolbarController = (props: {
     {
       placement,
       middleware: [offset(10), flip()],
-      onOpenChange: (open, event) => {
-        console.log("change", event);
+      onOpenChange: (open, _event) => {
+        // console.log("change", event);
         if (!open) {
           editor.formattingToolbar.closeMenu();
           editor.focus();

packages/react/src/components/SuggestionMenu/SuggestionMenu.test.tsx

@@ -33,12 +33,14 @@ it("has good typing", () => {
       suggestionMenuComponent={undefined as any}
       getItems={async () => [{ hello: "hello" }]}
       onItemClick={(item) => {
+        // eslint-disable-next-line no-console
         console.log(item.hello);
       }}
       triggerCharacter="/"
     />
   );
 
   // prevent typescript unused error
+  // eslint-disable-next-line no-console
   console.log("menu", menu);
 });

packages/react/src/schema/@util/ReactRenderUtil.ts

@@ -28,6 +28,7 @@ export function renderToDOMSpec(
 
   if (!div.childElementCount) {
     // TODO
+    // eslint-disable-next-line no-console
     console.warn("ReactInlineContentSpec: renderHTML() failed");
     return {
       dom: document.createElement("span"),

playground/src/main.tsx

@@ -96,7 +96,6 @@ const App = (props: { project: (typeof examples.basic)["projects"][0] }) => {
   React.useEffect(() => {
     (async () => {
       // load app async
-      console.log("../../" + props.project.pathFromRoot + "/App.tsx");
       const c: any = await modules[
         "../../" + props.project.pathFromRoot + "/App.tsx"
       ]();

tests/src/utils/components/Editor.tsx

@@ -1,13 +1,13 @@
 import { BlockNoteSchema, filterSuggestionItems } from "@blocknote/core";
 import "@blocknote/core/style.css";
+import { BlockNoteView } from "@blocknote/mantine";
+import "@blocknote/mantine/style.css";
 import {
   BlockNoteDefaultUI,
   SuggestionMenuController,
   getDefaultReactSlashMenuItems,
   useCreateBlockNote,
 } from "@blocknote/react";
-import { BlockNoteView } from "@blocknote/mantine";
-import "@blocknote/mantine/style.css";
 
 import { Alert, insertAlert } from "../customblocks/Alert";
 import { Button } from "../customblocks/Button";
@@ -24,8 +24,6 @@ const schema = BlockNoteSchema.create({
 export default function Editor() {
   const editor = useCreateBlockNote({ schema });
 
-  console.log(editor);
-
   // Give tests a way to get prosemirror instance
   (window as WindowWithProseMirror).ProseMirror = editor?._tiptapEditor;
   // editor.insertBlocks([{

tests/src/utils/customblocks/Alert.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import {
   BlockNoteEditor,
   BlockSchemaWithBlock,

tests/src/utils/customblocks/ReactAlert.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { BlockNoteEditor, defaultProps } from "@blocknote/core";
 import { createReactBlockSpec } from "@blocknote/react";
 import { useEffect, useState } from "react";