refactor: make into an internal API

Author: nperez0111

packages/core/src/api/positionMapping.ts

@@ -100,7 +100,7 @@ export class PositionStorage<
      * This is the side of the position to track. "left" is the default. "right" would move with the change if the change is in the right direction.
      */
     side: "left" | "right" = "left"
-  ): () => number {
+  ): () => number | undefined {
     const ySyncPluginState = ySyncPluginKey.getState(
       this.editor._tiptapEditor.state
     ) as YSyncPluginState;
@@ -136,7 +136,7 @@ export class PositionStorage<
 
       // This can happen if the element is deleted
       if (rel === null) {
-        throw new Error("Element deleted");
+        return undefined;
       }
 
       return rel + (side === "right" ? -1 : 0);

packages/core/src/editor/BlockNoteEditor.ts

@@ -368,6 +368,17 @@ export class BlockNoteEditor<
         contentComponent: any;
       } = undefined as any; // TODO: Type should actually reflect that it can be `undefined` in headless mode
 
+  /**
+   * Internal properties that are not part of the public API and may change in the future.
+   *
+   * @internal
+   */
+  public readonly _internal: {
+    /**
+     * Stores positions of elements in the editor.
+     */
+    positionStorage: PositionStorage<BSchema, ISchema, SSchema>;
+  };
   /**
    * Used by React to store a reference to an `ElementRenderer` helper utility to make sure we can render React elements
    * in the correct context (used by `ReactRenderUtil`)
@@ -396,11 +407,6 @@ export class BlockNoteEditor<
   public readonly inlineContentImplementations: InlineContentSpecs;
   public readonly styleImplementations: StyleSpecs;
 
-  /**
-   * Stores positions of elements in the editor.
-   */
-  public readonly positionStorage: PositionStorage<BSchema, ISchema, SSchema>;
-
   public readonly formattingToolbar: FormattingToolbarProsemirrorPlugin;
   public readonly linkToolbar: LinkToolbarProsemirrorPlugin<
     BSchema,
@@ -692,10 +698,12 @@ export class BlockNoteEditor<
       this.pmSchema = getSchema(tiptapOptions.extensions!);
     }
 
-    this.positionStorage = new PositionStorage<BSchema, ISchema, SSchema>(
-      this,
-      { shouldMount: !this.headless }
-    );
+    this._internal = {
+      positionStorage: new PositionStorage<BSchema, ISchema, SSchema>(this, {
+        shouldMount: !this.headless,
+      }),
+    };
+
     this.emit("create");
   }
 

packages/core/src/extensions/SuggestionMenu/SuggestionPlugin.ts

@@ -218,7 +218,7 @@ export class SuggestionMenuProseMirrorPlugin<
             suggestionPluginTransactionMeta !== null &&
             prev === undefined
           ) {
-            const trackedPosition = editor.positionStorage.track(
+            const trackedPosition = editor._internal.positionStorage.track(
               newState.selection.from -
                 // Need to account for the trigger char that was inserted, so we offset the position by the length of the trigger character.
                 suggestionPluginTransactionMeta.triggerCharacter.length
@@ -231,7 +231,7 @@ export class SuggestionMenuProseMirrorPlugin<
                 false,
               // When reading the queryStartPos, we offset the result by the length of the trigger character, to make it easy on the caller
               queryStartPos: () =>
-                trackedPosition() +
+                trackedPosition()! +
                 suggestionPluginTransactionMeta.triggerCharacter.length,
               query: "",
               decorationId: `id_${Math.floor(Math.random() * 0xffffffff)}`,