Bug with Last.fm as Metadata Provider – Artist Images Load but UI Crashes on Access

[gabriellxxix]

I'm currently testing different metadata providers in Lidarr v2.13.1.4676, specifically to address an issue where artist images are not being displayed, even when they exist in the artist's folder.

When using MusicBrainz or MetaMix, artist lookups are either slow or incomplete, and images are not shown. Even when a proper image is present in the artist's folder, Lidarr doesn't use it.

However, when switching to Last.fm via the Tubifarry plugin, searches become much faster and artist images load correctly in the search results. But here's the problem:

Once an artist is imported using Last.fm, accessing them via the interface causes the following critical error due to the way the artist URI is formed:

Working (MusicBrainz):
http://192.168.32.227:8686/artist/66c662b6-6e2f-4930-8610-912e24c63ed1

Broken (Last.fm):
http://192.168.32.227:8686/artist/Ace%20of%20Base@lastfm

This leads to a frontend crash with the following stack trace:

Pathname "/album/Ace of Base::100% Reggae Hits@lastfm" could not be decoded. This is likely caused by an invalid percent-encoding. at decodeURI (webpack://lidarr/node_modules/history/esm/history.js:87:12) at normalizeToLocation (webpack://lidarr/node_modules/react-router-dom/esm/react-router-dom.js:109:49)

It seems the unescaped special characters like @, %, and :: are not properly encoded or sanitized before being used in the React router, which results in UI failure.

Additionally, when using MetaMix, the artist search doesn’t return any results at all in my case

[TypNull]

It's getting late, so I'll jump on quickly and then head off.

When using MusicBrainz or MetaMix, artist lookups are either slow or incomplete, and images are not shown. Even when a proper image is present in the artist's folder, Lidarr doesn't use it.

This is normal behavior when the Lidarr API is experiencing downtime. Artist images are sourced from Fanart.tv, not MusicBrainz, so there's no workaround using Lidarr's standard functionality.

However, when switching to Last.fm via the Tubifarry plugin, searches become much faster and artist images load correctly in the search results.

Yes, but keep in mind that these are different artist entities, making migration back to MusicBrainz much more complex later. I also scrape the images directly from the Last.fm website.

Once an artist is imported using Last.fm, accessing them via the interface causes the following critical error due to the way the artist URI is formed

Interestingly, I'm experiencing the same issue right now, but the @ symbol isn't the problem since it's used across all metadata implementations.
I've found that "/album/Helloween::Gold Rock Ballads 1000%@lastfm" doesn't work while "/album/Cody Fry::Flying@lastfm" works fine, so the % character must be breaking the load function.

I'll fix this tomorrow or when I have time. I also really need to find a solution for the search functionality since it's hitting the API hard with calls, but I'm not sure how to fix my issue with this yet.
It would make searches much faster and less resource intensive, though that's not your problem here.

[TypNull]

Should be fixed in next release