Skip to content

Commit 35f58ac

Browse files
authored
[TT-13658] added missing logger from provider initialisation (#6729)
### **User description** <!-- Provide a general summary of your changes in the Title above --> TASK: https://tyktech.atlassian.net/browse/TT-13658 ## Description <!-- Describe your changes in detail --> ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** Bug fix ___ ### **Description** - Added a missing logger to the `Provider` initialization in the `upstreamoauth` middleware. - This change ensures that logging is properly configured, preventing potential issues related to missing logs. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>middleware.go</strong><dd><code>Add missing logger to Provider initialization</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> ee/middleware/upstreamoauth/middleware.go <li>Added a missing logger to the <code>Provider</code> initialization.<br> <li> Ensures that the <code>Logger</code> is properly set in the <code>upstreamOAuthProvider</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6729/files#diff-1347b256f3728407a2697f1e824391eaa329162e644741d8321f25c7a0630363">+1/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
1 parent 7081f2e commit 35f58ac

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ee/middleware/upstreamoauth/middleware.go

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func (m *Middleware) ProcessRequest(_ http.ResponseWriter, r *http.Request, _ in
8080
upstreamOAuthProvider := Provider{
8181
HeaderName: header.Authorization,
8282
AuthValue: payload,
83+
Logger: m.Logger(),
8384
}
8485

8586
headerName := provider.getHeaderName(m)

0 commit comments

Comments
 (0)