Repository navigation
Expand file tree
/
Copy pathschema.js
More file actions
392 lines (372 loc) · 12.3 KB
/
Copy pathschema.js
File metadata and controls
392 lines (372 loc) · 12.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
const logging = require('@tryghost/logging');
const { commands } = require('../../schema');
const DatabaseInfo = require('@tryghost/database-info');
const db = require('../../db');
const { createNonTransactionalMigration, createTransactionalMigration } = require('./migrations');
/**
* Builds a migration that runs inside a transaction on MySQL but NOT on SQLite.
*
* SQLite implements a column nullability change by rebuilding the whole table,
* which requires toggling `PRAGMA foreign_keys` — and that pragma is a no-op once
* a transaction is open. So on SQLite the migration must run non-transactionally
* (see applyNullableChange). MySQL alters the column in place and keeps the
* transaction it has always used.
*
* @param {(connection: import('knex').Knex) => Promise<void>} up
* @param {(connection: import('knex').Knex) => Promise<void>} down
* @returns {Migration}
*/
function createNullableMigration(up, down) {
const transaction = !DatabaseInfo.isSQLite(db.knex);
return {
config: {
transaction,
},
async up(config) {
await up(config.transacting || config.connection);
},
async down(config) {
await down(config.transacting || config.connection);
},
};
}
/**
* @param {string} table
* @param {string} column
* @param {Object} columnDefinition
*
* @returns {Migration}
*/
function createAddColumnMigration(table, column, columnDefinition, options = {}) {
return createNonTransactionalMigration(
// up
commands.createColumnMigration({
table,
column,
dbIsInCorrectState: (hasColumn) => hasColumn === true,
operation: commands.addColumn,
operationVerb: 'Adding',
columnDefinition,
options,
}),
// down
commands.createColumnMigration({
table,
column,
dbIsInCorrectState: (hasColumn) => hasColumn === false,
operation: commands.dropColumn,
operationVerb: 'Removing',
columnDefinition,
options,
}),
);
}
/**
* @param {string} table
* @param {string} column
* @param {Object} columnDefinition
*
* @returns {Migration}
*/
function createDropColumnMigration(table, column, columnDefinition, options = {}) {
return createNonTransactionalMigration(
// up
commands.createColumnMigration({
table,
column,
dbIsInCorrectState: (hasColumn) => hasColumn === false,
operation: commands.dropColumn,
operationVerb: 'Removing',
columnDefinition,
options,
}),
// down
commands.createColumnMigration({
table,
column,
dbIsInCorrectState: (hasColumn) => hasColumn === true,
operation: commands.addColumn,
operationVerb: 'Adding',
columnDefinition,
options,
}),
);
}
/**
* Applies a column nullability change, disabling foreign key checks around it in
* the way each database engine requires.
*
* SQLite implements a nullability change by rebuilding the whole table (create a
* temp table -> copy data -> DROP the original -> rename). That DROP fails on a
* table that other tables reference (e.g. `members`) unless foreign keys are
* disabled first. `PRAGMA foreign_keys` is a no-op once a transaction is open, so
* the SQLite migration runs non-transactionally (see createNullableMigration) and
* we toggle the pragma directly on the connection. The better-sqlite3 pool is
* fixed at a single connection, so the pragma applies to the same connection that
* runs the rebuild.
*
* MySQL alters the column in place inside the migration's transaction, so `knex`
* here is already that transaction. We only disable foreign key checks when the
* caller opts in; running `SET FOREIGN_KEY_CHECKS` on the transaction keeps it on
* the same connection as the ALTER.
*
* @param {import('knex').Knex} knex
* @param {'setNullable'|'dropNullable'} operation
* @param {string} table
* @param {string} column
* @param {boolean} [disableForeignKeyChecks] MySQL only; ignored on SQLite
*/
async function applyNullableChange(
knex,
operation,
table,
column,
disableForeignKeyChecks = false,
) {
if (DatabaseInfo.isSQLite(knex)) {
await knex.raw('PRAGMA foreign_keys = OFF;');
try {
await commands[operation](table, column, knex);
} finally {
await knex.raw('PRAGMA foreign_keys = ON;');
}
} else if (disableForeignKeyChecks) {
await knex.raw('SET FOREIGN_KEY_CHECKS=0;');
try {
await commands[operation](table, column, knex);
} finally {
await knex.raw('SET FOREIGN_KEY_CHECKS=1;');
}
} else {
await commands[operation](table, column, knex);
}
}
/**
* @param {string} table
* @param {string} column
* @param {Object} options
* @param {boolean} options.disableForeignKeyChecks Disable foreign key checks for the down operation (when dropping nullable)
* @returns {Migration}
*/
function createSetNullableMigration(table, column, options = {}) {
return createNullableMigration(
async function up(knex) {
try {
// Check if column is already nullable
const isNullable = await isColumnNullable(table, column, knex);
if (isNullable) {
logging.warn(
`Setting nullable: ${table}.${column} - skipping as column is already nullable`,
);
return;
}
} catch (error) {
// If we can't check the column status, proceed with the migration
// This maintains backward compatibility with implementation before checks were added
logging.warn(
`Could not check nullable status for ${table}.${column}, proceeding with migration: ${error.message}`,
);
}
logging.info(`Setting nullable: ${table}.${column}`);
await applyNullableChange(knex, 'setNullable', table, column);
},
async function down(knex) {
try {
// Check if column is already not nullable
const isNotNullable = await isColumnNotNullable(table, column, knex);
if (isNotNullable) {
logging.warn(
`Dropping nullable: ${table}.${column} - skipping as column is already not nullable`,
);
return;
}
} catch (error) {
// If we can't check the column status, proceed with the migration
// This maintains backward compatibility with implementation before checks were added
logging.warn(
`Could not check nullable status for ${table}.${column}, proceeding with migration: ${error.message}`,
);
}
logging.info(
`Dropping nullable: ${table}.${column}${options.disableForeignKeyChecks ? ' with foreign keys disabled' : ''}`,
);
await applyNullableChange(
knex,
'dropNullable',
table,
column,
options.disableForeignKeyChecks,
);
},
);
}
/**
* @param {string} table
* @param {string[]|string} columns One or multiple columns (in case the index should be for multiple columns)
* @param {object} [options]
* @param {number} [options.length] MySQL only: create a prefix index of this many characters
* @returns {Migration}
*/
function createAddIndexMigration(table, columns, options = {}) {
return createTransactionalMigration(
async function up(knex) {
await commands.addIndex(table, columns, knex, options);
},
async function down(knex) {
await commands.dropIndex(table, columns, knex);
},
);
}
/**
* @param {string} table
* @param {string} from
* @param {string} to
* @param {object} [options]
* @param {'instant'|'inplace'|'copy'|'auto'} [options.algorithm] - MySQL only
*
* @returns {Migration}
*/
function createRenameColumnMigration(table, from, to, options = {}) {
return createNonTransactionalMigration(
async function up(knex) {
const hasColumn = await knex.schema.hasColumn(table, to);
if (hasColumn) {
logging.warn(
`Renaming ${table}.${from} to ${table}.${to} column - skipping as column ${table}.${to} already exists`,
);
} else {
await commands.renameColumn(table, from, to, knex, options);
}
},
async function down(knex) {
const hasColumn = await knex.schema.hasColumn(table, from);
if (hasColumn) {
logging.warn(
`Renaming ${table}.${to} to ${table}.${from} column - skipping as column ${table}.${from} already exists`,
);
} else {
await commands.renameColumn(table, to, from, knex, options);
}
},
);
}
/**
* Check if a column is already not nullable
* @param {string} table
* @param {string} column
* @param {import('knex').Knex} knex
* @returns {Promise<boolean>}
*/
async function isColumnNotNullable(table, column, knex) {
if (DatabaseInfo.isSQLite(knex)) {
const response = await knex.raw('PRAGMA table_info(??)', [table]);
const columnInfo = response.find((col) => col.name === column);
return columnInfo && columnInfo.notnull === 1;
} else {
const response = await knex.raw('SHOW COLUMNS FROM ??', [table]);
const columnInfo = response[0].find((col) => col.Field === column);
return columnInfo && columnInfo.Null === 'NO';
}
}
/**
* Check if a column is already nullable
* @param {string} table
* @param {string} column
* @param {import('knex').Knex} knex
* @returns {Promise<boolean>}
*/
async function isColumnNullable(table, column, knex) {
if (DatabaseInfo.isSQLite(knex)) {
const response = await knex.raw('PRAGMA table_info(??)', [table]);
const columnInfo = response.find((col) => col.name === column);
return columnInfo && columnInfo.notnull === 0;
} else {
const response = await knex.raw('SHOW COLUMNS FROM ??', [table]);
const columnInfo = response[0].find((col) => col.Field === column);
return columnInfo && columnInfo.Null === 'YES';
}
}
/**
* @param {string} table
* @param {string} column
* @param {Object} options
* @param {boolean} options.disableForeignKeyChecks Disable foreign key checks for the up operation (when dropping nullable)
* @returns {Migration}
*/
function createDropNullableMigration(table, column, options = {}) {
return createNullableMigration(
async function up(knex) {
try {
// Check if column is already not nullable
const isNotNullable = await isColumnNotNullable(table, column, knex);
if (isNotNullable) {
logging.warn(
`Dropping nullable: ${table}.${column} - skipping as column is already not nullable`,
);
return;
}
} catch (error) {
// If we can't check the column status, proceed with the migration
// This maintains backward compatibility with implementation before checks were added
logging.warn(
`Could not check nullable status for ${table}.${column}, proceeding with migration: ${error.message}`,
);
}
logging.info(
`Dropping nullable: ${table}.${column}${options.disableForeignKeyChecks ? ' with foreign keys disabled' : ''}`,
);
await applyNullableChange(
knex,
'dropNullable',
table,
column,
options.disableForeignKeyChecks,
);
},
async function down(knex) {
try {
// Check if column is already nullable
const isNullable = await isColumnNullable(table, column, knex);
if (isNullable) {
logging.warn(
`Setting nullable: ${table}.${column} - skipping as column is already nullable`,
);
return;
}
} catch (error) {
// If we can't check the column status, proceed with the migration
// This maintains backward compatibility with implementation before checks were added
logging.warn(
`Could not check nullable status for ${table}.${column}, proceeding with migration: ${error.message}`,
);
}
logging.info(`Setting nullable: ${table}.${column}`);
await applyNullableChange(knex, 'setNullable', table, column);
},
);
}
module.exports = {
createAddColumnMigration,
createDropColumnMigration,
createSetNullableMigration,
createDropNullableMigration,
createRenameColumnMigration,
createAddIndexMigration,
};
/**
* @typedef {Object} TransactionalMigrationFunctionOptions
*
* @prop {import('knex').Knex} transacting
*/
/**
* @typedef {(options: TransactionalMigrationFunctionOptions) => Promise<void>} TransactionalMigrationFunction
*/
/**
* @typedef {Object} Migration
*
* @prop {Object} config
* @prop {boolean} config.transaction
*
* @prop {TransactionalMigrationFunction} up
* @prop {TransactionalMigrationFunction} down
*/