From fc13041c1359d26e24bdbe748f862b875ffc8eb5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=A0=D0=BE=D0=BC=D0=B0?= Date: Thu, 5 Apr 2018 12:28:03 +0800 Subject: [PATCH 1/2] fx --- src/services/api/assets.js | 3 +++ src/utils/index.js | 9 +++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/services/api/assets.js b/src/services/api/assets.js index b2a94c7..56d3980 100644 --- a/src/services/api/assets.js +++ b/src/services/api/assets.js @@ -34,6 +34,9 @@ const fetchPriceHistory = async (base, quote, days) => { ); // const prices = utils.formatPrices(utils.getPrices(history), base, quote); const prices = utils.getPrices(history); + console.log(quote.id); + console.log(history); + console.log(prices); return prices; } catch (error) { console.log(error); diff --git a/src/utils/index.js b/src/utils/index.js index 309ad4b..6fa9859 100644 --- a/src/utils/index.js +++ b/src/utils/index.js @@ -19,8 +19,13 @@ export const getPrices = (history) => { if (!history.length) return { first: 0, last: 0 }; const startElem = history[0]; const endElem = history[history.length - 1]; - const startPrice = startElem.open_base / startElem.open_quote; - const endPrice = endElem.close_base / endElem.close_quote; + // || 1 when node sends bad data ( 0 ) + const startPrice = (startElem.open_base || 1) / (startElem.open_quote || 1); + const endPrice = (endElem.close_base || 1) / (endElem.close_quote || 1); + if (!startElem.open_base || !startElem.close_base || + !startElem.open_quote || !endElem.close_quote) { + console.warn('[MARKET] : bad price history'); + } return { first: startPrice, last: endPrice }; }; From 4ca94ac0ca79910ca2976b9fabc2bf0cbe678ad2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=A0=D0=BE=D0=BC=D0=B0?= Date: Thu, 5 Apr 2018 12:29:10 +0800 Subject: [PATCH 2/2] cleanup --- src/services/api/assets.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/services/api/assets.js b/src/services/api/assets.js index 56d3980..b2a94c7 100644 --- a/src/services/api/assets.js +++ b/src/services/api/assets.js @@ -34,9 +34,6 @@ const fetchPriceHistory = async (base, quote, days) => { ); // const prices = utils.formatPrices(utils.getPrices(history), base, quote); const prices = utils.getPrices(history); - console.log(quote.id); - console.log(history); - console.log(prices); return prices; } catch (error) { console.log(error);