-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InternalError exceptions when handling user ids in roles #91
Comments
Tests after (there was no test covering the failing case before the fix):
|
tests.out.txt is the output of a complete test run, since this commit changes a library. Note that this test run also incorporates the patches from tickets #89 #90 #92 #93 #94 #95 too. The above test run omits the tests in machines.70.test.js, machines.80.test.js and machines.94.test.js, since my local dev machine has problems running VMX, thus I can't run any KVM or Bhyve tests. |
sdc-cloudapi currently uses node-mahi version 2.3.0. This version has a double-callback bug in its getUserById() implementation., which is exposed when using roles that have members identified by id instead of login. mahi client v2.3.1 fixes this.
Update cloudapi to use mahi client 2.3.3, and add tests to cover using "id" instead of "login" when creating or using roles.
The text was updated successfully, but these errors were encountered: