Skip to content

Commit f24d18c

Browse files
authored
Merge pull request #201 from Travlocks/refactor/#197-canvas
[fix] #197 템플릿 캔버스 조회 시 블록 기본 이미지 URL 미적용 수정
2 parents e9709b4 + ff84f8a commit f24d18c

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

src/main/java/org/umc/travlocksserver/domain/template/dto/response/TemplateCanvasVlockDTO.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public record TemplateCanvasVlockDTO(
1414
ConnectionPortType outputPort,
1515
Integer nextMoveMinutes,
1616
VlockBriefDTO vlock) {
17-
public static TemplateCanvasVlockDTO from(TemplateVlock cur, int nextMoveMinutes) {
17+
public static TemplateCanvasVlockDTO from(TemplateVlock cur, int nextMoveMinutes, String s3Domain) {
1818
return new TemplateCanvasVlockDTO(
1919
cur.getId(),
2020
cur.getOrderNo(),
@@ -24,6 +24,6 @@ public static TemplateCanvasVlockDTO from(TemplateVlock cur, int nextMoveMinutes
2424
cur.getInputPort(),
2525
cur.getOutputPort(),
2626
nextMoveMinutes,
27-
VlockBriefDTO.from(cur.getVlock()));
27+
VlockBriefDTO.from(cur.getVlock(), s3Domain));
2828
}
2929
}

src/main/java/org/umc/travlocksserver/domain/template/service/query/TemplateCanvasQueryService.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.umc.travlocksserver.domain.template.repository.TemplateDayRepository;
1818
import org.umc.travlocksserver.domain.template.repository.TemplateRepository;
1919
import org.umc.travlocksserver.domain.template.repository.TemplateVlockRepository;
20+
import org.umc.travlocksserver.global.aws.S3Properties;
2021

2122
import lombok.RequiredArgsConstructor;
2223

@@ -32,6 +33,8 @@ public class TemplateCanvasQueryService {
3233

3334
private final TemplateRouteQueryService templateRouteQueryService;
3435

36+
private final S3Properties s3Properties;
37+
3538
public TemplateCanvasResponseDTO getTemplateCanvas(Long templateId, Integer dayNo) {
3639

3740
Template template = templateRepository.findById(templateId)
@@ -59,7 +62,7 @@ public TemplateCanvasResponseDTO getTemplateCanvas(Long templateId, Integer dayN
5962
totalStayHours += cur.getStayHours();
6063
totalMoveMinutes += nextMoveMinutes;
6164

62-
vlocks.add(TemplateCanvasVlockDTO.from(cur, nextMoveMinutes));
65+
vlocks.add(TemplateCanvasVlockDTO.from(cur, nextMoveMinutes, s3Properties.domain()));
6366
}
6467

6568
double totalMoveHours = Math.round(((double)totalMoveMinutes / 60.0) * 100) / 100.0;

src/main/java/org/umc/travlocksserver/domain/vlock/dto/response/VlockBriefDTO.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,15 @@ public record VlockBriefDTO(
88
String category,
99
String coverImgUrl
1010
) {
11-
public static VlockBriefDTO from(Vlock vlock) {
11+
public static VlockBriefDTO from(Vlock vlock, String s3Domain) {
12+
String coverImgUrl = vlock.getCoverImgUrl();
13+
if (coverImgUrl == null || coverImgUrl.isBlank()) {
14+
coverImgUrl = s3Domain + vlock.getVlockCategory().getDefaultCreationImageKey();
15+
}
1216
return new VlockBriefDTO(
1317
vlock.getId(),
1418
vlock.getName(),
1519
vlock.getVlockCategory().getName(),
16-
vlock.getCoverImgUrl());
20+
coverImgUrl);
1721
}
1822
}

0 commit comments

Comments
 (0)