fix: make 'run' output honest on non-TTY and under --keep-going#48
Merged
ShixiangWang merged 1 commit intoJun 24, 2026
Merged
Conversation
Two related visibility fixes for `oxo-flow run`: - Non-TTY runs went silent because per-rule status was reported only through the indicatif progress bar, which auto-hides when stderr is not a terminal. Add a plain-text fallback (Running/✓/skip lines) so pipes, redirects, nohup, CI, and schedulers stay informative. The interactive progress bar is unchanged. - --keep-going swallowed executor errors and printed only a failure count. Collect failures and print a consolidated "Failed rules:" summary, and surface the previously-silent error path. Add an integration test for the non-TTY fallback and tighten the keep-going test to assert the new summary names the failed rule.
Member
|
Thanks for so quick response and PR:) |
Collaborator
Author
|
Of course! I will be working the silent failure memory bug next (should also be a relatively quick fix). Then I can focus on finishing the port of the phage pipline and continue testing. I have some thoughts on how to manage and bundle workflows with external scripts and environments, but I will write that up more formally later and share that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related visibility fixes for
oxo-flow run:Non-TTY runs no longer go silent. Per-rule status was reported only through the indicatif progress bar, which auto-hides when stderr isn't a terminal — so pipes, redirects,
nohup, CI, and schedulers showed nothing between the DAG listing and the final summary.Running: [i/n] <rule>,✓ <rule> (Xs), and skip lines--keep-goingno longer hides failures. It swallowed executor errors outright and printed only a failure count.Failed rules:summary (rule name + concise reason) at the endTests: adds an integration test for the non-TTY fallback; tightens the keep-going test to assert the summary names the failed rule.
make cipasses locally.