Skip to content

0f5322d 构建失败 #130

@github-actions

Description

@github-actions

构建在 commit 0f5322d 失败。

Commit Message:
硬编码路径优化完成 (#117)

已成功完成对硬编码路径的参数化优化。

修改内容

文件: rule/datapack.bzl

变更: 将第383行的硬编码路径 data/minecraft/tags/functions 参数化

  • 添加了两个局部常量 _MINECRAFT_TAGS_FUNCTIONS_PREFIX
    _MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX
  • 更新了 pkg_files 调用,使用变量替代硬编码字符串
  • 保持了与原有 strip_prefix 路径的一致性

具体变更:

# 定义 Minecraft 标签路径常量
_MINECRAFT_TAGS_FUNCTIONS_PREFIX = "data/minecraft/tags/functions"
_MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX = "data/minecraft/tags/function"

pkg_files(
    name = name + "_function_tag_legacy",
    visibility = visibility,
    srcs = [":%s_function_tag_legacy_compress" % name],
    prefix = _MINECRAFT_TAGS_FUNCTIONS_PREFIX,
    strip_prefix = _MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX,
)

验证结果

  • ✅ 语法检查通过:bazel query 验证目标存在
  • ✅ 构建测试通过:bazel build //subprojects/stone-disappearance:stone-disappearance 成功构建
  • ✅ 无破坏性变更:现有构建流程保持不变

优化效果

  1. 提高可维护性:路径集中管理,未来修改只需更新常量
  2. 提升代码清晰度:使用有意义的变量名替代魔术字符串
  3. 保持向后兼容:不改变现有构建行为,所有数据包构建不受影响

本次优化完成了 Issue 中提出的低优先级改进要求,使构建系统代码更加健壮和可维护。

Closes #115

New%20session%20-%202026-01-24T17%3A05%3A59.768Z
opencode
session
  |  github
run

查看失败的构建

构建日志片段
Extracting Bazel installation...
Starting local Bazel server (8.4.1) and connecting to it...
INFO: Invocation ID: 0decff28-c7d9-4a1b-978f-f82bba84e148
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
ERROR: /home/runner/work/E1epack/E1epack/rule/datapack.bzl:607:31: name '_ALL_MINECRAFT_VERSIONS' is not defined (did you mean 'ALL_MINECRAFT_VERSIONS'?)
WARNING: Target pattern parsing failed.
ERROR: Skipping '//...': error loading package under directory '': error loading package 'subprojects/ReplaceBlock': compilation of module 'rule/datapack.bzl' failed
ERROR: error loading package under directory '': error loading package 'subprojects/ReplaceBlock': compilation of module 'rule/datapack.bzl' failed
INFO: Elapsed time: 4.512s
INFO: 0 processes.
ERROR: Build did NOT complete successfully

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions