-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better pre-commit config #98
Comments
Please can you link some examples where it does not look good? |
btw https://github.com/google/yapf/#knobs <- config options for https://github.com/TomographicImaging/eqt/blob/main/pyproject.toml |
This comment was marked as off-topic.
This comment was marked as off-topic.
casperdcl
changed the title
Pre-commit forces commit on partial suggestions only
better pre-commit config
Jan 25, 2024
9 tasks
@casperdcl pointed out this is high priority for other repositories too, finalise before end of June 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pre-commit on GitHub checks the code and commits automatically part of the suggested changes. It leaves some suggestions unsolved with the red cross appearing and stopping the merge. It would be easier if we could run the checker online, receive a report from it and then decide to accept or reject the changes and fix some things manually. There are some issues, in particular, with long lines of code and alignment of # comments. The suggested edits and indentations do not look good.
I started to use the pre-commit offline in my local repository and it works well because the suggestions are not forced in a commit and I can amend them.
The text was updated successfully, but these errors were encountered: