Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the version constraint on CIL's dependencies #2034

Open
gfardell opened this issue Jan 9, 2025 · 0 comments
Open

Loosen the version constraint on CIL's dependencies #2034

gfardell opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@gfardell
Copy link
Member

gfardell commented Jan 9, 2025

CIL's conda build currently pins versions both numpy versions and the optional dependencies:

- {{ pin_compatible('numpy', min_pin='x.x', max_pin='x.x') }}

CIL/recipe/meta.yaml

Lines 76 to 80 in f0f97a4

run_constrained:
- tomophantom=2.0.0
- astra-toolbox>=1.9.9.dev5,<=2.1
- tigre>=2.4,<=2.6
- ccpi-regulariser=24.0.1

We want to free up these constraints and replace it with:

  1. Documented tested combinations either in the readme or landing page (python, numpy, tigre, astra, tomophantom, ccpi-regulariser)
  2. Environment files for conda install that will guarantee tested combinations

This will mean when newer versions are released it's simple to update the environment and run unit tests to confirm compatibility.

@gfardell gfardell added the enhancement New feature or request label Jan 9, 2025
@gfardell gfardell added this to the v25.0.0 milestone Jan 9, 2025
@gfardell gfardell added this to CIL work Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in CIL work Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant