test_cuda doesn't run all of our tests that require GPU

[lauramurgatroyd]

Description

The test_cuda github action should be running all of our tests that require GPU, but it isn't.

I came across this because on this action run we saw that the test_plot_filter (test_reconstructors.Test_GenericFilteredBackProjection.test_plot_filter) test failed on the docker action run, but the test-cuda action passed. The test-cuda action wasn't running this test.

The test-cuda action runs:

CIL/.github/workflows/build.yml

Line 56 in d58c330

TESTS_FORCE_GPU=1 python -m unittest discover -v -k tigre -k TIGRE -k astra -k ASTRA -k gpu -k GPU ./Wrappers/Python/test

This means it only runs tests that have one or more of the following in their name (or in the name of the class the test belongs to):

tigre, TIGRE, astra, ASTRA, gpu, GPU

https://docs.python.org/3/library/unittest.html#cmdoption-unittest-k

This means that multiple test classes that require tigre are missed out including Test_GenericFilteredBackProjection

Some possible solutions:

• Change it so that test-cuda runs all tests instead of just ones with specific keywords in
• Ensure every test that requires GPU has GPU in the test name or class name and add this requirement to the developer guide
• Add more key words to the test-cuda call to cover more test names

Environment

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)

[lauramurgatroyd]

The keywords also pick up tests in a module with the keyword in the name - so renaming test filenames could be an easier route