Skip to content

feat: fix duplicate execution start banner emission #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IfeDev1 merged 1 commit into from
Mar 29, 2026
Merged

feat: fix duplicate execution start banner emission #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/cli/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,9 @@ pub fn run(args: RunArgs, verbosity: Verbosity) -> Result<()> {
}

// Execute locally with debugging
if !args.is_json_output() {
println!("\n--- Execution Start ---\n");
}
// if !args.is_json_output() {
// println!("\n--- Execution Start ---\n");
// }
if args.instruction_debug {
print_info("Enabling instruction-level debugging...");
engine.enable_instruction_debug(&wasm_bytes)?;
Expand All @@ -687,7 +687,7 @@ pub fn run(args: RunArgs, verbosity: Verbosity) -> Result<()> {
return Ok(());
}
}

print_info("\n--- Execution Start ---\n");
output_writer.write("\n--- Execution Start ---\n")?;
let storage_before = engine.executor().get_storage_snapshot()?;
Expand Down
5 changes: 5 additions & 0 deletions src/plugin/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ pub fn check_api_version(plugin_version: u32) -> Result<(), crate::plugin::api::
}
Ok(())
}
} }

#[cfg(test)]
mod tests {
Expand Down Expand Up @@ -522,6 +523,7 @@ mod version_tests {
fn test_api_version_check() {
let result = check_api_version(999);
assert!(matches!(result, Err(PluginError::VersionMismatch { .. })));
}

#[test]
fn test_loader_creation() {
Expand Down Expand Up @@ -663,3 +665,6 @@ mod version_tests {
);
let result_ok = check_api_version(PLUGIN_API_VERSION);
assert!(result_ok.is_ok());
}
}
}
Loading