From ba1c7549707264ed32b9a8d123d7732b483b6fb1 Mon Sep 17 00:00:00 2001 From: strowi Date: Thu, 24 Apr 2025 14:35:24 +0200 Subject: [PATCH 1/4] feat(env-vars): add ADMINER_DEFAULT_DRIVER, ADMINER_DEFAULT_DBNAME to the possible environment variables --- .github/workflows/image.yml | 198 ++++++++++++++++++++---------------- 5/fastcgi/index.php | 53 ++++++---- 5/index.php | 55 ++++++---- 3 files changed, 179 insertions(+), 127 deletions(-) diff --git a/.github/workflows/image.yml b/.github/workflows/image.yml index 6d16a3c..5fa84fd 100644 --- a/.github/workflows/image.yml +++ b/.github/workflows/image.yml @@ -1,8 +1,8 @@ name: Build Docker Image on: -- push -- pull_request + - push + - pull_request jobs: build: @@ -10,92 +10,110 @@ jobs: strategy: matrix: variant: - - "4" - - "4/fastcgi" - - "5" - - "5/fastcgi" + - "4" + - "4/fastcgi" + - "5" + - "5/fastcgi" steps: - - uses: actions/checkout@v4 - - name: Build the image. - id: build - run: | - printf "::group::Sending context\n" - IMAGE=adminer:${VARIANT/\//-}-$(date +%s) - docker build "$VARIANT" --tag "$IMAGE" |sed 's/^Step/::endgroup::\n::group::Step/' - printf "::endgroup::\n" - printf "image=%s\n" "$IMAGE" >> $GITHUB_OUTPUT - printf "version=%s\n" "$(awk '/^ENV\s+ADMINER_VERSION/{print $3}' "$VARIANT/Dockerfile")" >> $GITHUB_OUTPUT - env: - VARIANT: ${{ matrix.variant }} - - name: Smoketest - run: | - docker run --name $container_name -d ${{ steps.build.outputs.image }} - env: - container_name: adminer_smoke - - name: Verify a restart works. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d ${{ steps.build.outputs.image }} - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ - docker restart $container_name - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ - env: - container_name: adminer_restart - - name: Verify version. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d ${{ steps.build.outputs.image }} - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ \ - |grep '${{ steps.build.outputs.version }}' - env: - container_name: adminer_version - - name: Verify that no warnings appear. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d ${{ steps.build.outputs.image }} - ! docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ \ - |grep 'Warning:' - env: - container_name: adminer_warnings - - name: Verify that the design works. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d -e ADMINER_DESIGN=nette ${{ steps.build.outputs.image }} - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ \ - |grep 'adminer.css' - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/adminer.css \ - |grep 'Nette' - env: - container_name: adminer_design - - name: Verify that the default server works. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d -e ADMINER_DEFAULT_SERVER=ADMINER_DEFAULT_SERVER_WORKS ${{ steps.build.outputs.image }} - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ \ - |grep 'ADMINER_DEFAULT_SERVER_WORKS' - env: - container_name: adminer_defaultserver - - name: Verify that loading plugins work. - if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} - run: | - docker run --name $container_name -d -e ADMINER_PLUGINS="tables-filter version-noverify" ${{ steps.build.outputs.image }} - docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ - curl -fsSL http://$container_name:8080/ \ - |grep 'verifyVersion =' - env: - container_name: adminer_plugins - - name: Show Containers and Images - run: | - printf "::group::docker ps -a\n" - docker ps -a - printf "::endgroup::\n" - printf "::group::docker images\n" - docker images - printf "::endgroup::\n" + - uses: actions/checkout@v4 + - name: Build the image. + id: build + run: | + printf "::group::Sending context\n" + IMAGE=adminer:${VARIANT/\//-}-$(date +%s) + docker build "$VARIANT" --tag "$IMAGE" |sed 's/^Step/::endgroup::\n::group::Step/' + printf "::endgroup::\n" + printf "image=%s\n" "$IMAGE" >> $GITHUB_OUTPUT + printf "version=%s\n" "$(awk '/^ENV\s+ADMINER_VERSION/{print $3}' "$VARIANT/Dockerfile")" >> $GITHUB_OUTPUT + env: + VARIANT: ${{ matrix.variant }} + - name: Smoketest + run: | + docker run --name $container_name -d ${{ steps.build.outputs.image }} + env: + container_name: adminer_smoke + - name: Verify a restart works. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ + docker restart $container_name + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ + env: + container_name: adminer_restart + - name: Verify version. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep '${{ steps.build.outputs.version }}' + env: + container_name: adminer_version + - name: Verify that no warnings appear. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d ${{ steps.build.outputs.image }} + ! docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'Warning:' + env: + container_name: adminer_warnings + - name: Verify that the design works. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d -e ADMINER_DESIGN=nette ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'adminer.css' + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/adminer.css \ + |grep 'Nette' + env: + container_name: adminer_design + - name: Verify that the default server works. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d -e ADMINER_DEFAULT_SERVER=ADMINER_DEFAULT_SERVER_WORKS ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'ADMINER_DEFAULT_SERVER_WORKS' + env: + container_name: adminer_defaultserver + - name: Verify that the default server works. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d -e ADMINER_DEFAULT_DRIVER=ADMINER_DEFAULT_DRIVER_WORKS ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'ADMINER_DEFAULT_DRIVER_WORKS' + env: + container_name: adminer_defaultdriver + - name: Verify that the default server works. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d -e ADMINER_DEFAULT_DBNAME=ADMINER_DEFAULT_DBNAME_WORKS ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'ADMINER_DEFAULT_DBNAME_WORKS' + env: + container_name: adminer_defaultdbname + - name: Verify that loading plugins work. + if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} + run: | + docker run --name $container_name -d -e ADMINER_PLUGINS="tables-filter version-noverify" ${{ steps.build.outputs.image }} + docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ + curl -fsSL http://$container_name:8080/ \ + |grep 'verifyVersion =' + env: + container_name: adminer_plugins + - name: Show Containers and Images + run: | + printf "::group::docker ps -a\n" + docker ps -a + printf "::endgroup::\n" + printf "::group::docker images\n" + docker images + printf "::endgroup::\n" diff --git a/5/fastcgi/index.php b/5/fastcgi/index.php index f336caf..b344a4a 100644 --- a/5/fastcgi/index.php +++ b/5/fastcgi/index.php @@ -2,25 +2,42 @@ namespace docker { function adminer_object() { /** - * Prefills the “Server” field with the ADMINER_DEFAULT_SERVER environment variable. + * Prefills the “Server”, "Driver", "DBName" fields with + * the ADMINER_DEFAULT_(SERVER,DRIVER,DBNAME) environment variables. */ - final class DefaultServerPlugin extends \Adminer\Plugin { - public function __construct( - private \Adminer\Adminer $adminer - ) { } - - public function loginFormField(...$args) { - return (function (...$args) { - $field = $this->loginFormField(...$args); - - return \str_replace( - 'name="auth[server]" value="" title="hostname[:port]"', - \sprintf('name="auth[server]" value="%s" title="hostname[:port]"', ($_ENV['ADMINER_DEFAULT_SERVER'] ?: 'db')), - $field, - ); - })->call($this->adminer, ...$args); - } - } + final class DefaultServerPlugin extends \Adminer\Plugin { + public function __construct( + private \Adminer\Adminer $adminer + ) { } + + public function loginFormField(...$args) { + return (function (...$args) { + $field = $this->loginFormField(...$args); + + $defaultDbDriver = getenv('ADMINER_DEFAULT_DRIVER') ?: 'server'; + $defaultDbHost = getenv('ADMINER_DEFAULT_SERVER') ?: ''; + $defaultDb = getenv('ADMINER_DEFAULT_DBNAME') ?: ''; + + $defaultDbDriver = $defaultDbDriver == 'mysql' ? 'server' : $defaultDbDriver; + + return \str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $field, + ); + })->call($this->adminer, ...$args); + } + } $plugins = []; foreach (glob('plugins-enabled/*.php') as $plugin) { diff --git a/5/index.php b/5/index.php index f336caf..3d8589d 100644 --- a/5/index.php +++ b/5/index.php @@ -1,26 +1,43 @@ loginFormField(...$args); - - return \str_replace( - 'name="auth[server]" value="" title="hostname[:port]"', - \sprintf('name="auth[server]" value="%s" title="hostname[:port]"', ($_ENV['ADMINER_DEFAULT_SERVER'] ?: 'db')), - $field, - ); - })->call($this->adminer, ...$args); - } - } + final class DefaultServerPlugin extends \Adminer\Plugin { + public function __construct( + private \Adminer\Adminer $adminer + ) { } + + public function loginFormField(...$args) { + return (function (...$args) { + $field = $this->loginFormField(...$args); + + $defaultDbDriver = getenv('ADMINER_DEFAULT_DRIVER') ?: 'server'; + $defaultDbHost = getenv('ADMINER_DEFAULT_SERVER') ?: ''; + $defaultDb = getenv('ADMINER_DEFAULT_DBNAME') ?: ''; + + $defaultDbDriver = $defaultDbDriver == 'mysql' ? 'server' : $defaultDbDriver; + + return \str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $field, + ); + })->call($this->adminer, ...$args); + } + } $plugins = []; foreach (glob('plugins-enabled/*.php') as $plugin) { From 3d98de60b3ba98f796dac6574345c1275d1a0c8d Mon Sep 17 00:00:00 2001 From: strowi Date: Thu, 24 Apr 2025 14:44:03 +0200 Subject: [PATCH 2/4] feat(env-vars): also extend the ADMINER_DEFAULT_*vars for v4 --- 4/fastcgi/index.php | 23 ++++++++++++++++++++++- 4/index.php | 23 ++++++++++++++++++++++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/4/fastcgi/index.php b/4/fastcgi/index.php index a48629f..0fcb4bb 100644 --- a/4/fastcgi/index.php +++ b/4/fastcgi/index.php @@ -10,7 +10,28 @@ function _callParent($function, $args) { $return = \Adminer::loginForm(); $form = ob_get_clean(); - echo str_replace('name="auth[server]" value="" title="hostname[:port]"', 'name="auth[server]" value="'.($_ENV['ADMINER_DEFAULT_SERVER'] ?: 'db').'" title="hostname[:port]"', $form); + // Set default values via env vars. + $defaultDbDriver = getenv('ADMINER_DEFAULT_DRIVER') ?: 'server'; + $defaultDbHost = getenv('ADMINER_DEFAULT_SERVER') ?: ''; + $defaultDb = getenv('ADMINER_DEFAULT_DBNAME') ?: ''; + + $defaultDbDriver = $defaultDbDriver == 'mysql' ? 'server' : $defaultDbDriver; + + echo str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $form + ); return $return; } diff --git a/4/index.php b/4/index.php index a48629f..0fcb4bb 100644 --- a/4/index.php +++ b/4/index.php @@ -10,7 +10,28 @@ function _callParent($function, $args) { $return = \Adminer::loginForm(); $form = ob_get_clean(); - echo str_replace('name="auth[server]" value="" title="hostname[:port]"', 'name="auth[server]" value="'.($_ENV['ADMINER_DEFAULT_SERVER'] ?: 'db').'" title="hostname[:port]"', $form); + // Set default values via env vars. + $defaultDbDriver = getenv('ADMINER_DEFAULT_DRIVER') ?: 'server'; + $defaultDbHost = getenv('ADMINER_DEFAULT_SERVER') ?: ''; + $defaultDb = getenv('ADMINER_DEFAULT_DBNAME') ?: ''; + + $defaultDbDriver = $defaultDbDriver == 'mysql' ? 'server' : $defaultDbDriver; + + echo str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $form + ); return $return; } From 62c4f1701962632773ae5f28361a7c8b118f5a4f Mon Sep 17 00:00:00 2001 From: strowi Date: Thu, 24 Apr 2025 14:54:15 +0200 Subject: [PATCH 3/4] style(indentation): tabs to spaces --- 4/fastcgi/index.php | 96 ++++++++++++++++++++++----------------------- 4/index.php | 96 ++++++++++++++++++++++----------------------- 5/fastcgi/index.php | 56 +++++++++++++------------- 5/index.php | 54 ++++++++++++------------- 4 files changed, 151 insertions(+), 151 deletions(-) diff --git a/4/fastcgi/index.php b/4/fastcgi/index.php index 0fcb4bb..b014a0e 100644 --- a/4/fastcgi/index.php +++ b/4/fastcgi/index.php @@ -1,64 +1,64 @@ MySQL', - 'name="auth[db]" value=""' - ], - [ - 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', - 'value="' . $defaultDbDriver . '" selected="selected"', - '>MySQL', - 'name="auth[db]" value="' . $defaultDb . '"' - ], - $form - ); + echo str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $form + ); - return $return; - } + return $return; + } - return parent::_callParent($function, $args); - } - } + return parent::_callParent($function, $args); + } + } - $plugins = []; - foreach (glob('plugins-enabled/*.php') as $plugin) { - $plugins[] = require($plugin); - } + $plugins = []; + foreach (glob('plugins-enabled/*.php') as $plugin) { + $plugins[] = require($plugin); + } - return new Adminer($plugins); - } + return new Adminer($plugins); + } } namespace { - if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { - header('Content-Type: text/css'); - readfile('adminer.css'); - exit; - } + if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { + header('Content-Type: text/css'); + readfile('adminer.css'); + exit; + } - function adminer_object() { - return \docker\adminer_object(); - } + function adminer_object() { + return \docker\adminer_object(); + } - require('adminer.php'); + require('adminer.php'); } diff --git a/4/index.php b/4/index.php index 0fcb4bb..b014a0e 100644 --- a/4/index.php +++ b/4/index.php @@ -1,64 +1,64 @@ MySQL', - 'name="auth[db]" value=""' - ], - [ - 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', - 'value="' . $defaultDbDriver . '" selected="selected"', - '>MySQL', - 'name="auth[db]" value="' . $defaultDb . '"' - ], - $form - ); + echo str_replace( + [ + 'name="auth[server]" value="" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '"', + 'selected="">MySQL', + 'name="auth[db]" value=""' + ], + [ + 'name="auth[server]" value="' . $defaultDbHost . '" title="hostname[:port]"', + 'value="' . $defaultDbDriver . '" selected="selected"', + '>MySQL', + 'name="auth[db]" value="' . $defaultDb . '"' + ], + $form + ); - return $return; - } + return $return; + } - return parent::_callParent($function, $args); - } - } + return parent::_callParent($function, $args); + } + } - $plugins = []; - foreach (glob('plugins-enabled/*.php') as $plugin) { - $plugins[] = require($plugin); - } + $plugins = []; + foreach (glob('plugins-enabled/*.php') as $plugin) { + $plugins[] = require($plugin); + } - return new Adminer($plugins); - } + return new Adminer($plugins); + } } namespace { - if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { - header('Content-Type: text/css'); - readfile('adminer.css'); - exit; - } + if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { + header('Content-Type: text/css'); + readfile('adminer.css'); + exit; + } - function adminer_object() { - return \docker\adminer_object(); - } + function adminer_object() { + return \docker\adminer_object(); + } - require('adminer.php'); + require('adminer.php'); } diff --git a/5/fastcgi/index.php b/5/fastcgi/index.php index b344a4a..11c19b5 100644 --- a/5/fastcgi/index.php +++ b/5/fastcgi/index.php @@ -1,10 +1,10 @@ hooks['loginFormField'][\array_key_last($this->hooks['loginFormField'])]; - if ($last instanceof \Adminer\Adminer) { - $defaultServerPlugin = new DefaultServerPlugin($last); - $this->plugins[] = $defaultServerPlugin; - $last = $defaultServerPlugin; - } - })->call($adminer); + (function () { + $last = &$this->hooks['loginFormField'][\array_key_last($this->hooks['loginFormField'])]; + if ($last instanceof \Adminer\Adminer) { + $defaultServerPlugin = new DefaultServerPlugin($last); + $this->plugins[] = $defaultServerPlugin; + $last = $defaultServerPlugin; + } + })->call($adminer); - return $adminer; - } + return $adminer; + } } namespace { - if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { - header('Content-Type: text/css'); - readfile('adminer.css'); - exit; - } + if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { + header('Content-Type: text/css'); + readfile('adminer.css'); + exit; + } - function adminer_object() { - return \docker\adminer_object(); - } + function adminer_object() { + return \docker\adminer_object(); + } - require('adminer.php'); + require('adminer.php'); } diff --git a/5/index.php b/5/index.php index 3d8589d..11c19b5 100644 --- a/5/index.php +++ b/5/index.php @@ -1,10 +1,10 @@ hooks['loginFormField'][\array_key_last($this->hooks['loginFormField'])]; - if ($last instanceof \Adminer\Adminer) { - $defaultServerPlugin = new DefaultServerPlugin($last); - $this->plugins[] = $defaultServerPlugin; - $last = $defaultServerPlugin; - } - })->call($adminer); + (function () { + $last = &$this->hooks['loginFormField'][\array_key_last($this->hooks['loginFormField'])]; + if ($last instanceof \Adminer\Adminer) { + $defaultServerPlugin = new DefaultServerPlugin($last); + $this->plugins[] = $defaultServerPlugin; + $last = $defaultServerPlugin; + } + })->call($adminer); - return $adminer; - } + return $adminer; + } } namespace { - if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { - header('Content-Type: text/css'); - readfile('adminer.css'); - exit; - } + if (basename($_SERVER['DOCUMENT_URI'] ?? $_SERVER['REQUEST_URI']) === 'adminer.css' && is_readable('adminer.css')) { + header('Content-Type: text/css'); + readfile('adminer.css'); + exit; + } - function adminer_object() { - return \docker\adminer_object(); - } + function adminer_object() { + return \docker\adminer_object(); + } - require('adminer.php'); + require('adminer.php'); } From 891ba459294e71f032722abdec4ea51607f30dad Mon Sep 17 00:00:00 2001 From: strowi Date: Thu, 24 Apr 2025 15:00:09 +0200 Subject: [PATCH 4/4] ci(default-tests): fix naming; default vaule for driver-test --- .github/workflows/image.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/image.yml b/.github/workflows/image.yml index 5fa84fd..fb9a213 100644 --- a/.github/workflows/image.yml +++ b/.github/workflows/image.yml @@ -73,7 +73,7 @@ jobs: |grep 'Nette' env: container_name: adminer_design - - name: Verify that the default server works. + - name: Verify that the default dbname works. if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} run: | docker run --name $container_name -d -e ADMINER_DEFAULT_SERVER=ADMINER_DEFAULT_SERVER_WORKS ${{ steps.build.outputs.image }} @@ -82,16 +82,16 @@ jobs: |grep 'ADMINER_DEFAULT_SERVER_WORKS' env: container_name: adminer_defaultserver - - name: Verify that the default server works. + - name: Verify that the default driver works. if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} run: | - docker run --name $container_name -d -e ADMINER_DEFAULT_DRIVER=ADMINER_DEFAULT_DRIVER_WORKS ${{ steps.build.outputs.image }} + docker run --name $container_name -d -e ADMINER_DEFAULT_DRIVER=pgsql ${{ steps.build.outputs.image }} docker run -i --rm --link $container_name:$container_name buildpack-deps:curl \ curl -fsSL http://$container_name:8080/ \ - |grep 'ADMINER_DEFAULT_DRIVER_WORKS' + |grep 'pgsql' env: container_name: adminer_defaultdriver - - name: Verify that the default server works. + - name: Verify that the default dbname works. if: ${{ ! contains(steps.build.outputs.image, 'fastcgi') }} run: | docker run --name $container_name -d -e ADMINER_DEFAULT_DBNAME=ADMINER_DEFAULT_DBNAME_WORKS ${{ steps.build.outputs.image }}