fix: exit each script with status code 0 for correct error handling in scripts

Author: TimDev9492

helpers/backup_server.sh

@@ -102,3 +102,5 @@ else
   echo "[ERROR] Backup failed."
   exit 1
 fi
+
+exit 0

helpers/install_server.sh

@@ -13,8 +13,11 @@ SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 cd "${SCRIPT_DIR}/../"
 source ./common/utils.sh
 
+# parse command line arguments
+parse_args flags args "$@"
+
 VERBOSE=false
-if in_array "-v" "$@"; then
+if in_array "-v" "${flags[@]}"; then
   VERBOSE=true
 fi
 
@@ -29,8 +32,14 @@ if [ ! -f "./load_config.sh" ]; then
 fi
 source ./load_config.sh
 
-# Read json string from stdin
-json_config=$(cat)
+# Read json string from first argument or stdin
+if [ -n "${args[0]}" ]; then
+  # Read from the first argument
+  json_config="${args[0]}"
+else
+  # Read from stdin
+  json_config=$(cat)
+fi
 
 # Test if json_config is a valid JSON object
 if ! echo "$json_config" | jq 'empty' 2>/dev/null; then
@@ -147,3 +156,5 @@ else
 fi
 
 log "[INFO] Successfully installed server '$server_alias' at $server_dir"
+
+exit 0

helpers/schedule_server_stop.sh

@@ -6,8 +6,8 @@ cd ${SCRIPT_DIR}
 source ../common/utils.sh
 
 if (($# < 2)); then
-    echo "Usage: $0 <server_alias> <seconds> <note|null> <kick_reason>"
-    exit 1
+  echo "Usage: $0 <server_alias> <seconds> <note|null> <kick_reason>"
+  exit 1
 fi
 
 server_alias="$1"
@@ -19,28 +19,30 @@ message="$*"
 print_timestamps=(300 180 120 60 30 10 5 4 3 2 1)
 
 while ((total_seconds > 0)); do
-    if in_array "$total_seconds" "${print_timestamps[@]}"; then
-        echo "[INFO] Stopping server $server_alias in $(print_time $total_seconds)"
-        prefix=""
-        [ "$note" != "null" ] && prefix="[$note] "
-        send_server_command "$server_alias" "say ${prefix}Stopping server in $(print_time $total_seconds)"
-        if [ ! "$?" -eq 0 ]; then
-            echo "[ERROR] Failed to send command to server $server_alias" >&2
-            exit 1
-        fi
+  if in_array "$total_seconds" "${print_timestamps[@]}"; then
+    echo "[INFO] Stopping server $server_alias in $(print_time $total_seconds)"
+    prefix=""
+    [ "$note" != "null" ] && prefix="[$note] "
+    send_server_command "$server_alias" "say ${prefix}Stopping server in $(print_time $total_seconds)"
+    if [ ! "$?" -eq 0 ]; then
+      echo "[ERROR] Failed to send command to server $server_alias" >&2
+      exit 1
     fi
-    sleep 1
-    ((total_seconds--))
+  fi
+  sleep 1
+  ((total_seconds--))
 done
 
 send_server_command "$server_alias" "kick @a $message"
 send_server_command "$server_alias" "stop"
 if [ ! "$?" -eq 0 ]; then
-    echo "[ERROR] Failed to stop server $server_alias" >&2
-    exit 1
+  echo "[ERROR] Failed to stop server $server_alias" >&2
+  exit 1
 fi
 
 # wait for server to stop
 while [ "$(get_server_status "$server_alias")" == "Running" ]; do
-    sleep 1
+  sleep 1
 done
+
+exit 0

javman.sh

@@ -8,9 +8,9 @@ SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 cd ${SCRIPT_DIR}
 source ./common/utils.sh
 
-# Parse command line arguments into flags and positional arguments
 VERBOSE=false
 
+# Parse command line arguments into flags and positional arguments
 parse_args flags args "$@"
 
 # parse the flags
@@ -173,3 +173,5 @@ install)
   exit 1
   ;;
 esac
+
+exit 0

papman.sh

@@ -8,6 +8,12 @@ SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 cd ${SCRIPT_DIR}
 source ./common/utils.sh
 
+# logging
+VERBOSE=false
+log() {
+  $VERBOSE && echo "$@" >&2
+}
+
 # Load variables
 if [ ! -f "./load_config.sh" ]; then
   echo "[ERROR] load_config.sh not found in the script directory." >&2
@@ -18,7 +24,13 @@ source ./load_config.sh
 # Check for required commands
 check_prerequisites
 
-# parse arguments
+# Parse command line arguments into flags and positional arguments
+parse_args flags args "$@"
+
+if in_array "-v" "${flags[@]}"; then
+  VERBOSE=true
+fi
+
 operations=("install" "list-versions" "list-builds" "link")
 
 print_usage() {
@@ -47,8 +59,8 @@ print_usage() {
   fi
 }
 
-if [ -z "$1" ]; then
-  print_usage "$1"
+if [ -z "${args[0]}" ]; then
+  print_usage "${args[0]}"
   exit 1
 fi
 
@@ -129,18 +141,18 @@ construct_latest_jar_name() {
   echo "${project}-latest.jar"
 }
 
-operation="$1"
+operation="${args[0]}"
 
 case "$operation" in
 install)
-  if [ -z "$2" ] || [ -z "$3" ] || [ -z "$4" ]; then
+  if [ -z "${args[1]}" ] || [ -z "${args[2]}" ] || [ -z "${args[3]}" ]; then
     print_usage "$operation"
     exit 1
   fi
 
-  project="$2"
-  version="$3"
-  build="$4"
+  project="${args[1]}"
+  version="${args[2]}"
+  build="${args[3]}"
 
   build_info=$(fetch_api "${PAPER_API_ENDPOINT}/projects/${project}/versions/${version}/builds/${build}")
   api_jar_name=$(echo "$build_info" |
@@ -170,7 +182,7 @@ install)
     chmod +x "${output_path}"
     latest_jar_filename=$(get_latest_build_file "$project" "$version")
     if [ "$latest_jar_filename" == "null" ]; then
-      echo "[ERROR] Unexpected failuer: No latest jar file found for project '$project' and version '$version'." >&2
+      echo "[ERROR] Unexpected failure: No latest jar file found for project '$project' and version '$version'." >&2
       exit 1
     fi
     # ln -sf "${jar_output_directory}/${latest_jar_filename}" "${jar_output_directory}/${project}-latest.jar"
@@ -182,27 +194,27 @@ install)
   fi
   ;;
 list-versions)
-  if [ -z "$2" ]; then
+  if [ -z "${args[1]}" ]; then
     print_usage "$operation"
     exit 1
   fi
 
-  list_versions "$2"
+  list_versions "${args[1]}"
   ;;
 list-builds)
-  if [ -z "$2" ] || [ -z "$3" ]; then
+  if [ -z "${args[1]}" ] || [ -z "${args[2]}" ]; then
     print_usage "$operation"
     exit 1
   fi
 
-  list_builds "$2" "$3"
+  list_builds "${args[1]}" "${args[2]}"
   ;;
 link)
-  link_name="$2"
-  project="$3"
-  version="$4"
-  build="$5"
-  channel="$6"
+  link_name="${args[1]}"
+  project="${args[2]}"
+  version="${args[3]}"
+  build="${args[4]}"
+  channel="${args[5]}"
   target_filename=''
   if [ -z "$link_name" ] || [ -z "$project" ] || [ -z "$version" ] || [ -z "$build" ]; then
     print_usage "$operation"
@@ -261,11 +273,13 @@ link)
     echo "[ERROR] Failed to create symlink '$link_name' -> '$target_filename'" >&2
     exit 1
   fi
-  echo "[INFO] Successfully linked '$link_name' to '$target_filename'" >&2
+  log "[INFO] Successfully linked '$link_name' to '$target_filename'" >&2
   ;;
 *)
   echo "[ERROR] Unknown operation: $operation" >&2
   print_usage
   exit 1
   ;;
 esac
+
+exit 0

serman.sh

@@ -18,9 +18,9 @@ source ./load_config.sh
 # Check for required commands
 check_prerequisites
 
-# Parse command line arguments into flags and positional arguments
 VERBOSE=false
 
+# Parse command line arguments into flags and positional arguments
 parse_args flags args "$@"
 
 # parse the flags
@@ -389,3 +389,5 @@ stop)
   exit 1
   ;;
 esac
+
+exit 0