Throw ArgumentException on type mismatches.

Author: teo-tsirpanis

sources/TileDB.CSharp/ThrowHelpers.cs

@@ -17,11 +17,11 @@ public static void ThrowTypeNotSupported() =>
         // We don't have to specify the type in the type argument, it can be seen from the stacktrace.
         [DoesNotReturn]
         public static void ThrowTypeMismatch(DataType type) =>
-            throw new InvalidOperationException($"Type is not compatible with data type {type}.");
+            throw new ArgumentException($"Type is not compatible with data type {type}.");
 
         [DoesNotReturn]
         public static void ThrowStringTypeMismatch(DataType type) =>
-            throw new InvalidOperationException($"Cannot encode data type {type} into strings.");
+            throw new ArgumentException($"Cannot encode data type {type} into strings.");
 
         [DoesNotReturn]
         public static void ThrowTooBigSize(ulong size, [CallerArgumentExpression(nameof(size))] string? paramName = null) =>

tests/TileDB.CSharp.Test/FragmentInfoTest.cs

@@ -172,11 +172,11 @@ public void TestMinimumBoundedRectanglesString()
             Assert.AreEqual(("a", "bb"), info.GetMinimumBoundedRectangle<string>(0, 0, 0));
             Assert.AreEqual(("c", "ddd"), info.GetMinimumBoundedRectangle<string>(0, 1, "d"));
 
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<int>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<long>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<int>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<long>(0, 0, 0));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<int>(0, 1, "d"));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<long>(0, 1, "d"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<int>(0, 1, "d"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<long>(0, 1, "d"));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(0, 1, "d"));
         }
 
@@ -199,11 +199,11 @@ public void TestMinimumBoundedRectangles()
             Assert.AreEqual((1, 2), info.GetMinimumBoundedRectangle<long>(0, 0, 0));
             Assert.AreEqual((7, 8), info.GetMinimumBoundedRectangle<long>(1, 1, "d1"));
 
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<int>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<string>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<int>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<string>(0, 0, 0));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<int>(1, 1, "d1"));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<string>(1, 1, "d1"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<int>(1, 1, "d1"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<string>(1, 1, "d1"));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(1, 1, "d1"));
         }
 
@@ -226,11 +226,11 @@ public void TestMinimumBoundedRectanglesInt32()
             Assert.AreEqual((1, 2), info.GetMinimumBoundedRectangle<int>(0, 0, 0));
             Assert.AreEqual((7, 8), info.GetMinimumBoundedRectangle<int>(1, 1, "d1"));
 
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<long>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<string>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<long>(0, 0, 0));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<string>(0, 0, 0));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(0, 0, 0));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<long>(1, 1, "d1"));
-            Assert.ThrowsException<InvalidOperationException>(() => info.GetMinimumBoundedRectangle<string>(1, 1, "d1"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<long>(1, 1, "d1"));
+            Assert.ThrowsException<ArgumentException>(() => info.GetMinimumBoundedRectangle<string>(1, 1, "d1"));
             Assert.ThrowsException<NotSupportedException>(() => info.GetMinimumBoundedRectangle<Guid>(1, 1, "d1"));
         }
 
@@ -268,8 +268,8 @@ public void TestNonEmptyDomain()
                         (int Start, int End, _) => (Start, End)
                     };
                     Assert.AreEqual(expectedNonEmptyDomain, actualNonEmptyDomain);
-                    Assert.ThrowsException<InvalidOperationException>(() => info.GetNonEmptyDomain<long>(i, dim));
-                    Assert.ThrowsException<InvalidOperationException>(() => info.GetNonEmptyDomain<string>(i, dim));
+                    Assert.ThrowsException<ArgumentException>(() => info.GetNonEmptyDomain<long>(i, dim));
+                    Assert.ThrowsException<ArgumentException>(() => info.GetNonEmptyDomain<string>(i, dim));
                     Assert.ThrowsException<NotSupportedException>(() => info.GetNonEmptyDomain<Guid>(i, dim));
 
                     string name = d.Name();
@@ -279,8 +279,8 @@ public void TestNonEmptyDomain()
                         (int Start, int End, _) => (Start, End)
                     };
                     Assert.AreEqual(expectedNonEmptyDomain, actualNonEmptyDomain);
-                    Assert.ThrowsException<InvalidOperationException>(() => info.GetNonEmptyDomain<long>(i, name));
-                    Assert.ThrowsException<InvalidOperationException>(() => info.GetNonEmptyDomain<string>(i, name));
+                    Assert.ThrowsException<ArgumentException>(() => info.GetNonEmptyDomain<long>(i, name));
+                    Assert.ThrowsException<ArgumentException>(() => info.GetNonEmptyDomain<string>(i, name));
                     Assert.ThrowsException<NotSupportedException>(() => info.GetNonEmptyDomain<Guid>(i, name));
                 }
             }

tests/TileDB.CSharp.Test/QueryTest.cs

@@ -50,13 +50,13 @@ public void TestGlobalQuery(LayoutType layoutType, ArrayType arrayType)
             {
                 using var subarray = new Subarray(array);
                 subarray.AddRange("rows", 1, 4);
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.AddRange<long>("rows", 1, 4));
+                Assert.ThrowsException<ArgumentException>(() => subarray.AddRange<long>("rows", 1, 4));
                 Assert.AreEqual((1, 4), subarray.GetRange<int>("rows", 0));
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.GetRange<long>("rows", 0));
+                Assert.ThrowsException<ArgumentException>(() => subarray.GetRange<long>("rows", 0));
                 subarray.AddRange(1, 1, 2); // cols
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.AddRange<long>(1, 1, 2));
+                Assert.ThrowsException<ArgumentException>(() => subarray.AddRange<long>(1, 1, 2));
                 Assert.AreEqual((1, 2), subarray.GetRange<int>(1, 0));
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.GetRange<long>(1, 0));
+                Assert.ThrowsException<ArgumentException>(() => subarray.GetRange<long>(1, 0));
                 queryWrite.SetSubarray(subarray);
                 queryWrite.SetDataReadOnlyBuffer<int>("a1", new[] { 1, 2, 3, 4, 5, 6, 7, 8 }.AsMemory());
             }
@@ -181,8 +181,8 @@ public void TestDenseQuery()
             using (var subarray = new Subarray(array))
             {
                 subarray.SetSubarray<sbyte>(0, 1);
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.SetSubarray(0, 1));
-                Assert.ThrowsException<InvalidOperationException>(() => subarray.SetSubarray(0));
+                Assert.ThrowsException<ArgumentException>(() => subarray.SetSubarray(0, 1));
+                Assert.ThrowsException<ArgumentException>(() => subarray.SetSubarray(0));
                 query.SetSubarray(subarray);
             }