Skip to content

bug: character issues with umlauts #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tobiasehlert opened this issue Apr 18, 2025 · 0 comments · May be fixed by #471
Open

bug: character issues with umlauts #470

tobiasehlert opened this issue Apr 18, 2025 · 0 comments · May be fixed by #471
Assignees
@tobiasehlert
Labels
bug Something isn't working

Comments

@tobiasehlert
Copy link
Member

tobiasehlert commented Apr 18, 2025 •
edited
Loading

Something related to umlauts (äöü) doesn't seem right when requesting data upstream.

Example characters:

Reported by Skylife on Discord.
@tobiasehlert tobiasehlert added the bug Something isn't working label Apr 18, 2025
@tobiasehlert tobiasehlert self-assigned this Apr 18, 2025
Skyliife added a commit to Skyliife/tibiadata-api-go that referenced this issue Apr 18, 2025
@Skyliife
fix: character issues with umlauts
8f87eb9 
link to issue: TibiaData#470

- Wrap incoming HTML in charset.NewReader before goquery parsing
- Ensures ISO‑8859‑1 (and other legacy) input is normalized to UTF‑8
- Prevents “mojibake” (e.g. “ä” instead of “ä”)
- Updated TestWorldAntica to simulate Latin‑1 input and verify correct Umlaut decoding
- Added Antica.html for parsing character Näurin

Closes TibiaData#470
@Skyliife Skyliife linked a pull request Apr 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasehlert tobiasehlert

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: character issues with umlauts Skyliife/tibiadata-api-go
1 participant
@tobiasehlert