Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleF seems to double the pdf #19

Open
GoogleCodeExporter opened this issue May 12, 2015 · 2 comments
Open

SampleF seems to double the pdf #19

GoogleCodeExporter opened this issue May 12, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Hi again,

It seems to me that SampleF returns the double of the pdf:


When adding 
Pdf += m_Lambertian.Pdf(Wol, Wil);
Pdf += m_Microfacet.Pdf(Wol, Wil);

Pdf is already set and non zero. Furthermore why is here no Importance sampling 
applied.

What I am asking is, could you please tell me the reason behind this.


Regards
Christoph


HOD CColorXyz SampleF(const Vec3f& Wo, Vec3f& Wi, float& Pdf, const 
CBrdfSample& S)
    {
        const Vec3f Wol = WorldToLocal(Wo);
        Vec3f Wil;

        CColorXyz R;

        if (S.m_Component <= 0.5f)
        {
            m_Lambertian.SampleF(Wol, Wil, Pdf, S.m_Dir);
        }
        else
        {
            m_Microfacet.SampleF(Wol, Wil, Pdf, S.m_Dir);
        }

        Pdf += m_Lambertian.Pdf(Wol, Wil);
        Pdf += m_Microfacet.Pdf(Wol, Wil);

        R += m_Lambertian.F(Wol, Wil);
        R += m_Microfacet.F(Wol, Wil);

        Wi = LocalToWorld(Wil);

        return R;
    }

Original issue reported on code.google.com by [email protected] on 13 Jun 2012 at 1:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant