Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Check permissions more thoroughly #14

Open
keenerb opened this issue Dec 11, 2015 · 0 comments
Open

Suggestion: Check permissions more thoroughly #14

keenerb opened this issue Dec 11, 2015 · 0 comments

Comments

@keenerb
Copy link

keenerb commented Dec 11, 2015

I haven't been able to compile and test your version, but Magicspells has always suffered from a pretty severe problem with dynamically adding/removing spells with permissions.

If you add a spell with magicspells.grant.spellname and cast.spellname, if you revoke those permissions the player is still able to cast the spells until they relog or you execute /cast reload as an admin.

I believe that permissions should be re-checked at spell cast, at spell selection via item, and at any /cast command, and non-granted/unknown spells should be purged from the characters spell list.

Also, an option to disable spellbook saving/loading would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant