Bad read offset for PS5 version?

[stevemonaco]

I'm working on a refactor fork (not sure if it will get to the finish line) and noticed the following code:

PS5NorModifier/UART-CL By TheCod3r/UART-CL By TheCod3r/Program.cs

Lines 431 to 460 in 3064e07

	#region Get PS5 version
	try
	{
	BinaryReader reader = new BinaryReader(new FileStream(pathToDump, FileMode.Open));
	//Set the position of the reader
	reader.BaseStream.Position = offsetOne;
	//Read the offset
	offsetOneValue = BitConverter.ToString(reader.ReadBytes(12)).Replace("-", null);
	reader.Close();
	}
	catch
	{
	// Obviously this value is invalid, so null the value and move on
	offsetOneValue = null;
	}
	try
	{
	BinaryReader reader = new BinaryReader(new FileStream(pathToDump, FileMode.Open));
	//Set the position of the reader
	reader.BaseStream.Position = offsetOne;
	//Read the offset
	offsetTwoValue = BitConverter.ToString(reader.ReadBytes(12)).Replace("-", null);
	reader.Close();
	}
	catch
	{
	// Obviously this value is invalid, so null the value and move on
	offsetTwoValue = null;
	}

Assigning offsetOne to reader.BaseStream.Position for both reads which seems strange. So I think there's a bug. Unfortunately, I can't test the software at the moment.

[nickidw]

It should prob use offsetOneValue instead of offsetOne in the 2nd read.

[stevemonaco]

More like offsetTwo.