bim-label font size and line heigth #55
Labels
bug
Something isn't working
Comments
GoulielmosFloros
added a commit
to GoulielmosFloros/engine_ui-components
that referenced
this issue
Mar 2, 2025
…atOpen#56. For this one ThatOpen#56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts. I also fixed a related issue with regards to the bim-label size and line height with ref ThatOpen#55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work. To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size. Reviewed-by: Goulielmos Floros Ref: ThatOpen#56
8 tasks
GoulielmosFloros
added a commit
to GoulielmosFloros/engine_ui-components
that referenced
this issue
Mar 18, 2025
…atOpen#56. For this one ThatOpen#56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts. I also fixed a related issue with regards to the bim-label size and line height with ref ThatOpen#55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work. To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size. Reviewed-by: Goulielmos Floros Ref: ThatOpen#56
8 tasks
HoyosJuan
pushed a commit
that referenced
this issue
Apr 1, 2025
… (#67) * fix: bim-icon scg image position & bim-label font-size/line height #56. For this one #56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts. I also fixed a related issue with regards to the bim-label size and line height with ref #55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work. To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size. Reviewed-by: Goulielmos Floros Ref: #56 * fix: updates on examples * update examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug 📝
When I change the font size in a bim-label component, the height of the row remains the same and it will not be updated to the new font size. I noticed that the problem could be in the line-height set to 1.1rem, probably it should be 1.1em so it will adapt on the font size of the parent element.
Situation with 1.1rem:
Situation with 1.1em:
Reproduction▶️
No response
Steps to reproduce 🔢
Create a bim-label element and set the font size to 50px for example
System Info 💻
Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅
The text was updated successfully, but these errors were encountered: