Retain cycle with AddArtistsViewController and AddArtistsViewModel

[ThasianX]

Description

Navigating out of the AddArtistsViewController doesn't deallocate the AddArtistsViewController and the AddArtistsViewModel. These are signs of a retain cycle.

Expected Behavior

A message in the console should print out that AddArtistsViewController and the AddArtistsViewModel were deallocated.

Actual Behavior

No message in the console prints out that AddArtistsViewController and the AddArtistsViewModel were deallocated.

Steps to Reproduce the Problem

1. Run the app and navigate to the New Releases screen.
2. Click the portfolio icon at the top right, taking you to the portfolio page
3. Click the add button at the top right of the portfolio, taking you to the add artists page
4. Swipe downwards to dismiss the modal view.
5. Look at the console: only the AddArtistsCoordinator was deallocated.

Possible solution

I think it has something to do with the SearchController and the AddArtistsViewController's strong reference to it. Could play around with 'weak' and see what happens.

Specifications

• XCode Version: 11