Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro solutions about banner #69

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

AK4266
Copy link
Contributor

@AK4266 AK4266 commented Mar 15, 2023

Purpose

The purpose of this PR is to fix #67
The problem is whenever the screen size is between 992px - 1200px. About section leaves empty space to the right

Approach

I used mx-auto w-50

Screenshots

Screenshot 2023-03-15 183151

Learning

@AK4266 AK4266 closed this Mar 15, 2023
@AK4266 AK4266 reopened this Mar 15, 2023
@Tharindu37
Copy link
Owner

@AK4266 Can you check again?

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 15, 2023

Yes

@Tharindu37
Copy link
Owner

@AK4266 Use the git pull upstream development command before the develop

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 15, 2023

Okay

@Tharindu37
Copy link
Owner

@AK4266 Can you resolve the conflicts

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 16, 2023

Okay...

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 16, 2023

@Tharindu37 I just resolved the conflicts

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 16, 2023

Hi @Tharindu37 can you review my pr

@Tharindu37
Copy link
Owner

background-image:linear-gradient(rgba(0, 0, 0, 0.527),rgba(0, 0, 0, 0.5)) , url(assets/solutions-min.jpg);
@AK4266 Remove this code line and delete the relevant image

@AK4266
Copy link
Contributor Author

AK4266 commented Mar 16, 2023

@Tharindu37 I removed the code line , but i wasn't able to remove the image. Can you tell me how do i do that

@Tharindu37
Copy link
Owner

@AK4266 after commit and push

@Tharindu37
Copy link
Owner

Tharindu37 commented Mar 16, 2023

@AK4266 There are some issue. Use the "git pull upstream developmet" code. You shoud delete the "solutions-min.jpg" image in your working directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Company Banner
2 participants