Content does not SupportsVisual (type checking issue)

[davidfokkema]

Hi, this issue came up on Discord, but maybe someone here knows the answer. If I have:

yield Static(Content("Hello, [this is not markup]World!"))

in my compose() method, all is fine. The static renders the text, without parsing the 'markup'. However, when I run mypy on this code it complains:

error: Argument 1 to "Static" has incompatible type "Content"; expected "ConsoleRenderable | RichCast | str | SupportsVisual"  [arg-type]

Since the possible content types include SupportsVisual and since Content subclasses Visual, which, I would guess, would certainly support Visual, I'd say mypy is wrong here. My hunch is that this would sooner be a Textual typing issue than a bug in mypy, but I'd like to know if anyone here understands what's wrong. Thanks!

[TomJGooding]

From a quick look the type might just need updating to VisualType, the same as the update method?

[davidfokkema]

Ah, thanks! The commit introducing that seems to indicate that, indeed. I will create a PR. Thanks again!

[davidfokkema]

From the code:

VisualType: TypeAlias = "RenderableType | SupportsVisual | Visual"

Further confirmation.