Skip to content

Unify Dashboard round sound with Settings soundEnabled store #457

Description

@josephchimebuka

Problem

Round-end audio on the dashboard uses a separate localStorage key (xelma_round_sound) while /settings persists sound preferences in useSettingsStore via audioController. Users can enable sounds in one place and still hear silence (or vice versa).

Scope

  • Remove the ad-hoc xelma_round_sound toggle/state from Dashboard.tsx
  • Read soundEnabled from useSettingsStore (and respect audioController bindings)
  • Play round-resolution cues only when settings sound is enabled
  • Add/adjust unit coverage for the unified path

Acceptance criteria

  • Single source of truth for UI sounds (useSettingsStore.soundEnabled)
  • Settings test tone and round-end cue share the same preference
  • No orphaned xelma_round_sound localStorage writes
  • pnpm test passes

Files

  • src/pages/Dashboard.tsx
  • src/store/useSettingsStore.ts
  • src/utils/audioController.ts
  • src/pages/Settings.test.tsx

Difficulty

beginner

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or requestfrontendFrontend/Stellar wave trackinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions