Referenced assembly discussion

[jeffward01]

In terms of references, I think we add only what’s in system and then users should add anything else they need.
In terms of NuGet packages, I don’t think we should add anything to the compilation by default, but I think we should provide a nice succinct interface to allow a user to add a package should they wish too.
From: Jeff Ward @.>
Sent: 10 November 2022 22:50
To: Testura/Testura.Code @.>
Cc: Sean Farrow @.>; Mention @.>
Subject: Re: [Testura/Testura.Code] Is this repo abandoned? (Issue #91)

I think my main question was what types/assemblies do we want added by default? From: Jeff Ward @.> Sent: 10 November 2022 16:26 To: Testura/Testura.Code @.> Cc: Sean Farrow @.>; Mention @.> Subject: Re: [Testura/Testura.Code] Is this repo abandoned? (Issue #91#91) OK, cool. What about adding default references, currently we add them based on files, should we add them based on types, if yes which types really matter. From: Mille Boström @.> Sent: 20 October 2022 17:58 To: Testura/Testura.Code @.> Cc: Sean Farrow @.>; Mention @.> Subject: Re: [Testura/Testura.Code] Is this repo abandoned? (Issue #91#91<#91#91>) There are no real reason to support that old version of .NET framework so if you have to update it just go for it. According to nuget.org we only support .NET 6 anyway so I think we should just embrace it and try to keep up with the latest version as good as we can. — Reply to this email directly, view it on GitHub<#91#91 (comment)<#91 (comment)#91 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALDK7VT3O6BU6MVYL6XYL3WEF2XXANCNFSM6AAAAAARE5WDQE. You are receiving this because you were mentioned.Message ID: @.> I’m not quite sure what you mean by this - references to packages or framework versions? Can you clarify a bit and give some examples? I don’t quite understand what you mean — Reply to this email directly, view it on GitHub<#91 (comment)#91 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALDK7WLBTNCS25OXG44YYLWHUO2NANCNFSM6AAAAAARE5WDQE. You are receiving this because you were mentioned.Message ID: @.>

I think just net7.0 standard assemblies - and only necessary nuget packages ( I have to review I’m not sure what is necessary or not)

Do you have any suggestions?

—
Reply to this email directly, view it on GitHub#91 (comment), or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALDK7UG4PCPBV6QX7LFUBTWHV3ZXANCNFSM6AAAAAARE5WDQE.
You are receiving this because you were mentioned.Message ID: @.***>

Originally posted by @SeanFarrow in #91 (comment)

[jeffward01]

@SeanFarrow - let me break down your points so we can discuss:

1.)

In terms of references, I think we add only what’s in system and then users should add anything else they need.

Like nuget packages? Im not quite sure I understand your comment. Can you explain more please with an example?

2.)

In terms of NuGet packages, I don’t think we should add anything to the compilation by default, but I think we should provide a nice succinct interface to allow a user to add a package should they wish too.

Currently the only included nuget packages are:

    <ItemGroup>
      <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.0.1" />
      <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
    </ItemGroup>

A user can add a their own nuget packages to their own implementation of course if they want. I don't understand what you mean here:

I don’t think we should add anything to the compilation by default, but I think we should provide a nice succinct interface to allow a user to add a package should they wish too.

Can you explain more please with an example?

[SeanFarrow]

@jeffward01
I'll take them in order:
What is the minimum set of references (in terms of assemblies) we should add to the compilation for a user?
Secondly, should we provide a easy way for a user to add a NuGet package to the compilation?

I hope this is clearer?