Fix failing test

Author: vbreuss

Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs

@@ -45,7 +45,7 @@ public string Combine(string path1, string path2)
 				throw new ArgumentNullException(nameof(path2));
 			}
 
-			return Combine([path1, path2]);
+			return CombineInternal([path1, path2]);
 		}
 
 		/// <inheritdoc cref="IPath.Combine(string, string, string)" />
@@ -66,7 +66,7 @@ public string Combine(string path1, string path2, string path3)
 				throw new ArgumentNullException(nameof(path3));
 			}
 
-			return Combine([path1, path2, path3]);
+			return CombineInternal([path1, path2, path3]);
 		}
 
 		/// <inheritdoc cref="IPath.Combine(string, string, string, string)" />
@@ -92,12 +92,12 @@ public string Combine(string path1, string path2, string path3, string path4)
 				throw new ArgumentNullException(nameof(path4));
 			}
 
-			return Combine([path1, path2, path3, path4]);
+			return CombineInternal([path1, path2, path3, path4]);
 		}
 
 		/// <inheritdoc cref="IPath.Combine(string[])" />
 		public string Combine(params string[] paths)
-			=> System.IO.Path.Combine(paths);
+			=> CombineInternal(paths);
 
 #if FEATURE_PATH_ADVANCED
 		/// <inheritdoc cref="IPath.EndsInDirectorySeparator(ReadOnlySpan{char})" />
@@ -280,15 +280,15 @@ public bool IsPathRooted(ReadOnlySpan<char> path)
 #if FEATURE_PATH_JOIN
 		/// <inheritdoc cref="IPath.Join(ReadOnlySpan{char}, ReadOnlySpan{char})" />
 		public string Join(ReadOnlySpan<char> path1, ReadOnlySpan<char> path2)
-			=> Join(path1.ToString(), path2.ToString());
+			=> JoinInternal([path1.ToString(), path2.ToString()]);
 #endif
 
 #if FEATURE_PATH_JOIN
 		/// <inheritdoc cref="IPath.Join(ReadOnlySpan{char}, ReadOnlySpan{char}, ReadOnlySpan{char})" />
 		public string Join(ReadOnlySpan<char> path1,
 			ReadOnlySpan<char> path2,
 			ReadOnlySpan<char> path3)
-			=> Join(path1.ToString(), path2.ToString(), path3.ToString());
+			=> JoinInternal([path1.ToString(), path2.ToString(), path3.ToString()]);
 #endif
 
 #if FEATURE_PATH_ADVANCED
@@ -297,7 +297,7 @@ public string Join(ReadOnlySpan<char> path1,
 			ReadOnlySpan<char> path2,
 			ReadOnlySpan<char> path3,
 			ReadOnlySpan<char> path4)
-			=> Join(path1.ToString(), path2.ToString(), path3.ToString(), path4.ToString());
+			=> JoinInternal([path1.ToString(), path2.ToString(), path3.ToString(), path4.ToString()]);
 #endif
 
 #if FEATURE_PATH_ADVANCED
@@ -314,7 +314,7 @@ public string Join(string? path1, string? path2)
 				return path1;
 			}
 
-			return Join([path1, path2]);
+			return JoinInternal([path1, path2]);
 		}
 #endif
 
@@ -337,7 +337,7 @@ public string Join(string? path1, string? path2, string? path3)
 				return Join(path1, path2);
 			}
 
-			return Join([path1, path2, path3]);
+			return JoinInternal([path1, path2, path3]);
 		}
 #endif
 
@@ -365,14 +365,14 @@ public string Join(string? path1, string? path2, string? path3, string? path4)
 				return Join(path1, path2, path3);
 			}
 
-			return Join([path1, path2, path3, path4]);
+			return JoinInternal([path1, path2, path3, path4]);
 		}
 #endif
 
 #if FEATURE_PATH_ADVANCED
 		/// <inheritdoc cref="IPath.Join(string[])" />
 		public string Join(params string?[] paths)
-			=> System.IO.Path.Join(paths);
+			=> JoinInternal(paths);
 #endif
 
 #if FEATURE_PATH_ADVANCED
@@ -407,5 +407,11 @@ public bool TryJoin(ReadOnlySpan<char> path1,
 #endif
 
 		#endregion
+
+		private static string CombineInternal(string[] paths)
+			=> System.IO.Path.Combine(paths);
+
+		private static string JoinInternal(string?[] paths)
+			=> System.IO.Path.Join(paths);
 	}
 }

Tests/Testably.Abstractions.Testing.Tests/Helpers/PathHelperTests.cs

@@ -129,7 +129,7 @@ public void ThrowCommonExceptionsIfPathIsInvalid_WithInvalidCharacters(
 	{
 		MockFileSystem fileSystem = new(i => i
 			.SimulatingOperatingSystem(SimulationMode.Windows));
-		string path = fileSystem.Path.GetFullPath(invalidChar + "path");
+		string path = invalidChar + "path";
 
 		Exception? exception = Record.Exception(() =>
 		{
@@ -138,10 +138,10 @@ public void ThrowCommonExceptionsIfPathIsInvalid_WithInvalidCharacters(
 
 #if NETFRAMEWORK
 		exception.Should().BeOfType<ArgumentException>()
-			.Which.Message.Should().Contain($"'{path}'");
+			.Which.Message.Should().Contain(path);
 #else
 		exception.Should().BeOfType<IOException>()
-			.Which.Message.Should().Contain($"'{path}'");
+			.Which.Message.Should().Contain(path);
 #endif
 	}