Skip to content

Commit 4496dfa

Browse files
committed
Fix review issues
1 parent 5ca1036 commit 4496dfa

2 files changed

Lines changed: 16 additions & 14 deletions

File tree

Source/Mockolate/Web/ItExtensions.HttpContent.IsStringContent.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,11 @@ protected override bool Matches(HttpContent value)
125125
{
126126
#if NET8_0_OR_GREATER
127127
Stream stream = value.ReadAsStream();
128+
using StreamReader reader = new(stream, leaveOpen: true);
128129
#else
129130
Stream stream = value.ReadAsStreamAsync().ConfigureAwait(false).GetAwaiter().GetResult();
130-
#endif
131131
using StreamReader reader = new(stream);
132+
#endif
132133
string content = reader.ReadToEnd();
133134
switch (_bodyMatchType)
134135
{

Source/Mockolate/Web/ItExtensions.cs

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -106,30 +106,30 @@ public bool Matches(Uri uri)
106106

107107
private sealed class FormDataMatcher
108108
{
109-
private readonly List<(string Name, HttpFormDataValue Value)> _requiredQueryParameters = [];
109+
private readonly List<(string Name, HttpFormDataValue Value)> _requiredFormDataParameters = [];
110110

111111
public FormDataMatcher(string name, HttpFormDataValue value)
112112
{
113-
_requiredQueryParameters.Add((name, value));
113+
_requiredFormDataParameters.Add((name, value));
114114
}
115115

116-
public FormDataMatcher(IEnumerable<(string Name, HttpFormDataValue Value)> queryParameters)
116+
public FormDataMatcher(IEnumerable<(string Name, HttpFormDataValue Value)> formDataParameters)
117117
{
118-
_requiredQueryParameters.AddRange(queryParameters);
118+
_requiredFormDataParameters.AddRange(formDataParameters);
119119
}
120120

121-
public FormDataMatcher(string queryParameters)
121+
public FormDataMatcher(string formDataParameters)
122122
{
123-
_requiredQueryParameters.AddRange(
124-
ParseQueryParameters(queryParameters)
123+
_requiredFormDataParameters.AddRange(
124+
ParseFormDataParameters(formDataParameters)
125125
.Select(pair => (pair.Key, new HttpFormDataValue(pair.Value))));
126126
}
127127

128128
public bool Matches(HttpContent content)
129129
{
130-
List<(string Key, string Value)> queryParameters = GetFormData(content).ToList();
131-
return _requiredQueryParameters.All(requiredParameter
132-
=> queryParameters.Any(p
130+
List<(string Key, string Value)> formDataParameters = GetFormData(content).ToList();
131+
return _requiredFormDataParameters.All(requiredParameter
132+
=> formDataParameters.Any(p
133133
=> p.Key == requiredParameter.Name &&
134134
requiredParameter.Value.Matches(p.Value)));
135135
}
@@ -144,16 +144,17 @@ public bool Matches(HttpContent content)
144144

145145
#if NET8_0_OR_GREATER
146146
Stream stream = content.ReadAsStream();
147+
using StreamReader reader = new(stream, leaveOpen: true);
147148
#else
148149
Stream stream = content.ReadAsStreamAsync().ConfigureAwait(false).GetAwaiter().GetResult();
149-
#endif
150150
using StreamReader reader = new(stream);
151+
#endif
151152
string rawFormData = reader.ReadToEnd();
152153

153-
return ParseQueryParameters(rawFormData);
154+
return ParseFormDataParameters(rawFormData);
154155
}
155156

156-
private static IEnumerable<(string Key, string Value)> ParseQueryParameters(string input)
157+
private static IEnumerable<(string Key, string Value)> ParseFormDataParameters(string input)
157158
=> input.TrimStart('?')
158159
.Split('&')
159160
.Select(pair => pair.Split('=', 2))

0 commit comments

Comments
 (0)