Don't pass TCM::Config->args to test class constructors

Also deprecate this method since it's no longer needed.

Author: autarch

Changes

@@ -2,6 +2,13 @@ Revision history for Perl distribution Test-Class-Moose
 
 {{$NEXT}}
 
+  [BACKWARDS INCOMPATIBILITIES]
+
+  * The value of Test::Class::Moose::Config->args is no longer passed to the
+    constructor for each test class instance. This was a holdover from when
+    Test::Class::Moose was both a parent class for your test classes and the
+    test class runner. Fixes GH #68. Reported by Noel Maddy.
+
 0.78     2016-08-21
 
   [ENHANCEMENTS]

lib/Test/Class/Moose.pm

@@ -877,6 +877,16 @@ for you, see L<Test::Class::Moose::Role::AutoUse> in this distribution.
 
 =head1 DEPRECATIONS AND BACKWARDS INCOMPATIBILITIES
 
+=head2 Version 0.79
+
+=over 4
+
+=item *
+
+The L<Test::Class::Moose::Config> class's C<args> method is now
+deprecated. was a holdover from when Test::Class::Moose was both a parent
+class for your test classes and the test class runner.
+
 =head2 Version 0.77
 
 =over 4

lib/Test/Class/Moose/Config.pm

@@ -10,6 +10,8 @@ use Moose;
 use Moose::Util::TypeConstraints;
 use namespace::autoclean;
 
+use Test::Class::Moose::Deprecated;
+
 subtype 'ArrayRefOfStrings', as 'Maybe[ArrayRef[Str]]';
 
 coerce 'ArrayRefOfStrings', from 'Str', via { defined($_) ? [$_] : undef };
@@ -99,6 +101,8 @@ has 'test_classes' => (
 sub args {
     my $self = shift;
 
+    Test::Class::Moose::Deprecated::deprecated();
+
     return (
         map { defined $self->$_ ? ( $_ => $self->$_ ) : () }
         map { $_->name } $self->meta->get_all_attributes
@@ -194,10 +198,9 @@ Boolean. Will run test classes in a random order.
 
 =head2 C<args>
 
- my $tests = Some::Test::Class->new($test_suite->test_configuration->args);
-
-Returns a hash of the args used to build the configuration. Used in
-testing. You probably won't need it.
+Returns a hash of the args used to build the configuration. This used to be
+used internally, but is now retained simply for backwards compatibility. You
+probably won't need it.
 
 =cut
 

lib/Test/Class/Moose/Deprecated.pm

@@ -11,7 +11,7 @@ use 5.10.0;
 our $VERSION = '0.79';
 
 use Package::DeprecationManager 0.16 -deprecations => {
-    'Test::Class::Moose->runtests' => '0.55',
+    'Test::Class::Moose::Config::args' => '0.79',
 };
 
 1;
@@ -31,16 +31,14 @@ deprecated in L<Test::Class::Moose>.
 
 If you specify C<< -api_version => $version >>, you can use deprecated features
 without warnings. Note that this special treatment is limited to the package
-that loads C<Moose::Deprecated>.
+that loads C<Test::Class::Moose::Deprecated>.
 
 =head1 DEPRECATIONS BY VERSION
 
 The following features were deprecated in past versions and will now warn:
 
-=head2 Test::Class::Moose->runtests
+=head2 Test::Class::Moose::Config->args
 
-This was deprecated in version 0.55.
-
-Use L<Test::Class::Moose::Runner> to run tests instead.
+This was deprecated in version 0.79.
 
 =cut

lib/Test/Class/Moose/Role/Executor.pm

@@ -113,7 +113,6 @@ sub _run_test_instances {
     my $class_report = shift;
 
     my @test_instances = $test_class->_tcm_make_test_class_instances(
-        $self->test_configuration->args,
         test_report => $self->test_report,
     );
 

t/basiclib/TestsFor/Basic.pm

@@ -75,7 +75,7 @@ sub expected_test_events {
                 call max   => 4;
                 call trace => object {
                     call package => 'Test::Class::Moose::Role::Executor';
-                    call line    => 152;
+                    call line    => 151;
                     call subname => 'Test::Class::Moose::Util::context_do';
                 };
             };