Merge pull request #3619 from vlon/v3.2.x-instasst

fix: 修复模型关联n-n时，俩实例之间的关联可以重复创建的bug
Former-commit-id: e543ed0

Author: breezeli

resources/errors/common/default/topo_server.json

@@ -83,6 +83,7 @@
     "1101059": "bk_inst_name %s 值有重复",
     "1101060": "关联类型已经被使用",
 	"1101061": "关联关系为1:n的，不能同时关联多个源模型实例",
+	"1101062": "两实例间已经存在关联，不能重复创建",
 	"1001060":"创建模型分组唯一失败",
 	"1001061":"更新模型分组唯一失败",
 	"1001062":"删除模型分组唯一失败",

resources/errors/english/en/topo_server.json

@@ -83,6 +83,7 @@
     "1101059": "bk_inst_name %s is duplicate.",
     "1101060": "association kind has already been used.",
 	"1101061": "The relationship is 1:n, and multiple source model instances cannot be associated at the same time.",
+	"1101062": "There is already an association between the two instances and cannot be created repeatedly",
 	"1001060":"create model unique constrains failed",
 	"1001061":"update model unique constrains failed",
 	"1001062":"delete model unique constrains failed",

src/common/errInfo.go

@@ -310,6 +310,8 @@ const (
 	CCErrorTopoAssociationKindHasBeenUsed = 1101060
 	// create new instance for a new association, but association map is 1:n
 	CCErrorTopoCreateMultipleInstancesForOneToManyAssociation = 1101061
+	// create instance association, but two instances are already associated
+	CCErrorAssociationBetweenTwoInstacneAlreadyExist = 1101062
 
 	CCErrTopoAppDeleteFailed                       = 1001031
 	CCErrTopoAppUpdateFailed                       = 1001032

src/scene_server/topo_server/core/operation/association.go

@@ -612,8 +612,25 @@ func (a *association) CreateInst(params types.ContextParams, request *metadata.C
 		return nil, err
 	}
 
-	switch modelAsst.Mapping {
+	// Check if two instances are already associated
+	cond = condition.CreateCondition()
+	cond.Field(common.BKInstIDField).Eq(request.InstId)
+	cond.Field(common.BKAsstInstIDField).Eq(request.AsstInstId)
+	cond.Field(common.AssociationObjAsstIDField).Eq(request.ObjectAsstId)
+	instAsst, err := a.SearchInst(params, &metadata.SearchAssociationInstRequest{Condition: cond.ToMapStr()})
+	if err != nil {
+		blog.Errorf("create association instance, but check instance with cond[%v] failed, err: %v", cond, err)
+		return nil, params.Err.Error(common.CCErrCommHTTPDoRequestFailed)
+	}
+	if !instAsst.Result {
+		blog.Errorf("create association instance, but check instance with cond[%v] failed, err: %s", cond, resp.ErrMsg)
+		return nil, params.Err.New(resp.Code, resp.ErrMsg)
+	}
+	if len(instAsst.Data) >= 1 {
+		return nil, params.Err.Error(common.CCErrorAssociationBetweenTwoInstacneAlreadyExist)
+	}
 
+	switch modelAsst.Mapping {
 	case metatype.OneToOneMapping:
 		cond := condition.CreateCondition()
 		cond.Field(common.AssociationObjAsstIDField).Eq(request.ObjectAsstId)