Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated GH release action #159

Open
winsmith opened this issue Jun 14, 2024 · 2 comments
Open

Add automated GH release action #159

winsmith opened this issue Jun 14, 2024 · 2 comments
Assignees

Comments

@winsmith
Copy link
Contributor

Similar to https://github.com/TelemetryDeck/FlutterSDK/blob/main/.github/workflows/set-version.yml , create an action that increases the version number. Also update the Readme file to point at that action.

@winsmith winsmith self-assigned this Jun 14, 2024
@Jeehut
Copy link
Contributor

Jeehut commented Dec 1, 2024

This seems to be a duplicate of #100.

@Jeehut
Copy link
Contributor

Jeehut commented Feb 14, 2025

@winsmith I don't think we need this. Making a release is already as simple as bumping the version num, adding a tag in Git, and pushing. One has to add a tag anyways, and one needs a clear commit where the tag needs to be added to, which has always been a "Bump version num" commit which only does that. This seems pretty straightforward and the process doesn't hold any potential for forgetting to bump the version number. There are also not two places or so, it's exactly one place in code, so we have a single point of failure.

I think this can be closed without action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants