Skip to content

Commit 0eb0934

Browse files
authored
Publish SDK Version with each request (#7)
* Publish SDK Version with each request * Update tests to new format
1 parent bd6502b commit 0eb0934

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/telemetrydeck.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ export class TelemetryDeck {
7575
appID: _app,
7676
clientUser: _user,
7777
sessionID: _user,
78-
telemetryClientVersion: version,
7978
type: type ?? 'pageview',
8079
payload: transformPayload({
8180
url,
@@ -84,6 +83,7 @@ export class TelemetryDeck {
8483
platform: userAgentData ?? '',
8584
vendor,
8685
...payload,
86+
telemetryClientVersion: `JavaScriptSDK ${version}`,
8787
}),
8888
},
8989
]),

tests/telemetrydeck.test.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ describe('TelemetryDeck.signal()', () => {
5252
appID: 'foo',
5353
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
5454
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
55-
telemetryClientVersion: version,
5655
type: 'pageview',
5756
payload: [
5857
`url:${location.href}`,
5958
`useragent:${navigator.userAgent}`,
6059
`locale:${navigator.language}`,
6160
`platform:${navigator.userAgentData ?? ''}`,
6261
`vendor:${navigator.vendor}`,
62+
`telemetryClientVersion:JavaScriptSDK ${version}`,
6363
],
6464
},
6565
]),
@@ -84,14 +84,14 @@ describe('TelemetryDeck.signal()', () => {
8484
appID: 'foo',
8585
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
8686
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
87-
telemetryClientVersion: version,
8887
type: 'pageview',
8988
payload: [
9089
`url:${location.href}`,
9190
`useragent:${navigator.userAgent}`,
9291
`locale:${navigator.language}`,
9392
`platform:${navigator.userAgentData ?? ''}`,
9493
`vendor:${navigator.vendor}`,
94+
`telemetryClientVersion:JavaScriptSDK ${version}`,
9595
],
9696
},
9797
]),
@@ -107,7 +107,6 @@ describe('TelemetryDeck.signal()', () => {
107107
appID: 'foo',
108108
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
109109
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
110-
telemetryClientVersion: version,
111110
type: 'pageview',
112111
payload: [
113112
`url:${location.href}`,
@@ -116,6 +115,7 @@ describe('TelemetryDeck.signal()', () => {
116115
`platform:${navigator.userAgentData ?? ''}`,
117116
`vendor:${navigator.vendor}`,
118117
`baz:bat`,
118+
`telemetryClientVersion:JavaScriptSDK ${version}`,
119119
],
120120
},
121121
]),

0 commit comments

Comments
 (0)