From 96bd86fd7df64d70463195e2ead15106563e46bf Mon Sep 17 00:00:00 2001 From: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com> Date: Wed, 17 Jun 2026 14:56:05 +0200 Subject: [PATCH 1/2] Don't convert to Path again if it's already a Path --- src/teich/converter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/teich/converter.py b/src/teich/converter.py index c43798c..366a219 100644 --- a/src/teich/converter.py +++ b/src/teich/converter.py @@ -3628,7 +3628,7 @@ def _convert_jsonl_file_to_training_rows(jsonl_file: Path) -> list[dict[str, Any def convert_traces_to_training_data(traces_dir: Path | str) -> list[dict[str, Any]]: - source = Path(traces_dir) + source = traces_dir if not isinstance(traces_dir, Path) else Path(traces_dir) trace_files = _jsonl_files(source) rows: list[dict[str, Any]] = [] for path in trace_files: From b18cb66dc7fbb2c0d59bee761b236273aeecccc5 Mon Sep 17 00:00:00 2001 From: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com> Date: Wed, 17 Jun 2026 14:59:00 +0200 Subject: [PATCH 2/2] wrong order --- src/teich/converter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/teich/converter.py b/src/teich/converter.py index 366a219..f7f0b0a 100644 --- a/src/teich/converter.py +++ b/src/teich/converter.py @@ -3628,7 +3628,7 @@ def _convert_jsonl_file_to_training_rows(jsonl_file: Path) -> list[dict[str, Any def convert_traces_to_training_data(traces_dir: Path | str) -> list[dict[str, Any]]: - source = traces_dir if not isinstance(traces_dir, Path) else Path(traces_dir) + source = Path(traces_dir) if not isinstance(traces_dir, Path) else traces_dir trace_files = _jsonl_files(source) rows: list[dict[str, Any]] = [] for path in trace_files: