Skip to content

Commit be65dd1

Browse files
authored
cartservice: fix health Check() method signature (GoogleCloudPlatform#57)
- Use the method provided in HealthBase - Use the same version of GrpcHealth as Grpc core. Fixes GoogleCloudPlatform#50.
1 parent c61a8ae commit be65dd1

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Diff for: src/cartservice/HealthImpl.cs

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
using System;
2+
using System.Threading.Tasks;
23
using cartservice.interfaces;
4+
using Grpc.Core;
35
using Grpc.Health.V1;
46
using StackExchange.Redis;
57
using static Grpc.Health.V1.Health;
@@ -11,12 +13,12 @@ public HealthImpl (ICartStore dependency) {
1113
this.dependency = dependency;
1214
}
1315

14-
public HealthCheckResponse Check (HealthCheckRequest request) {
16+
public override Task<HealthCheckResponse> Check(HealthCheckRequest request, ServerCallContext context){
1517
Console.WriteLine ("Checking CartService Health");
1618

17-
return new HealthCheckResponse {
19+
return Task.FromResult(new HealthCheckResponse {
1820
Status = dependency.Ping() ? HealthCheckResponse.Types.ServingStatus.Serving : HealthCheckResponse.Types.ServingStatus.NotServing
19-
};
21+
});
2022
}
2123
}
22-
}
24+
}

Diff for: src/cartservice/cartservice.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<PackageReference Include="Google.Protobuf" Version="3.6.1" />
1111
<PackageReference Include="Google.Protobuf.Tools" Version="3.5.1" />
1212
<PackageReference Include="grpc" Version="1.12.0" />
13-
<PackageReference Include="Grpc.HealthCheck" Version="1.15.0" />
13+
<PackageReference Include="Grpc.HealthCheck" Version="1.12.0" />
1414
<PackageReference Include="grpc.tools" Version="1.12.0" />
1515
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
1616
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.1" />

0 commit comments

Comments
 (0)