Climbing routes api - Zoe #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Dec 10, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job with your first API Zoe! Just remember going forward that endpoints should be named after what they return so a RESTful approach is to include all filter options as query params in your main endpoint, e.g. /climbing-routes?type=sport&difficulty=low
Comment on lines
+23
to
+25
| app.get("/climbingRoutes", (_, res) => { | ||
| res.json(climbingRoutes); | ||
| }); |
Contributor
There was a problem hiding this comment.
Instead of creating different endpoints for each filter/sorting option, you should just include all of the query params under this endpoint. This way you can also chain the filters, if anyone wants to filter on e.g. type and difficulty.
This is good practice to make your API RESTful.
Comment on lines
+119
to
+128
| app.get("/climbingRoutes/:id", (req, res) => { | ||
| const id = req.params.id; | ||
|
|
||
| const climbingRoute = climbingRoutes.find((route) => route.id === +id); | ||
| if (climbingRoute) { | ||
| res.json(climbingRoute); | ||
| } else { | ||
| res.status(404).send("No climbing route found with that ID"); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
⭐ Nice with some error handling as well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://project-express-api-mqhs.onrender.com/