Skip to content

Commit f441036

Browse files
committed
[Bandcamp] Upgrade incoming links to HTTPS
1 parent 02e14b8 commit f441036

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.schabi.newpipe.extractor.exceptions.ReCaptchaException;
1717
import org.schabi.newpipe.extractor.localization.DateWrapper;
1818
import org.schabi.newpipe.extractor.utils.ImageSuffix;
19+
import org.schabi.newpipe.extractor.utils.Utils;
1920

2021
import java.io.IOException;
2122
import java.nio.charset.StandardCharsets;
@@ -171,7 +172,11 @@ public static boolean isArtistDomain(final String url) throws ParsingException {
171172

172173
try {
173174
// Test other URLs for whether they contain a footer that links to bandcamp
174-
return Jsoup.parse(NewPipe.getDownloader().get(url).responseBody())
175+
return Jsoup.parse(
176+
NewPipe.getDownloader()
177+
.get(Utils.replaceHttpWithHttps(url))
178+
.responseBody()
179+
)
175180
.getElementsByClass("cart-wrapper")
176181
.get(0)
177182
.getElementsByTag("a")

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/linkHandler/BandcampChannelLinkHandlerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ public static BandcampChannelLinkHandlerFactory getInstance() {
3333
@Override
3434
public String getId(final String url) throws ParsingException, UnsupportedOperationException {
3535
try {
36-
final String response = NewPipe.getDownloader().get(url).responseBody();
36+
final String response = NewPipe.getDownloader().get(Utils.replaceHttpWithHttps(url))
37+
.responseBody();
3738

3839
// Use band data embedded in website to extract ID
3940
final JsonObject bandData = JsonUtils.getJsonData(response, "data-band");

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/linkHandler/BandcampCommentsLinkHandlerFactory.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import org.schabi.newpipe.extractor.exceptions.ParsingException;
44
import org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory;
55
import org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper;
6+
import org.schabi.newpipe.extractor.utils.Utils;
67

78
import java.util.List;
89

@@ -24,7 +25,7 @@ public static BandcampCommentsLinkHandlerFactory getInstance() {
2425

2526
@Override
2627
public String getId(final String url) throws ParsingException, UnsupportedOperationException {
27-
return url;
28+
return Utils.replaceHttpWithHttps(url);
2829
}
2930

3031
@Override
@@ -47,6 +48,6 @@ public String getUrl(final String id,
4748
final List<String> contentFilter,
4849
final String sortFilter)
4950
throws ParsingException, UnsupportedOperationException {
50-
return id;
51+
return Utils.replaceHttpWithHttps(id);
5152
}
5253
}

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/linkHandler/BandcampPlaylistLinkHandlerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.schabi.newpipe.extractor.exceptions.ParsingException;
66
import org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory;
77
import org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper;
8+
import org.schabi.newpipe.extractor.utils.Utils;
89

910
import java.util.List;
1011

@@ -33,7 +34,7 @@ public String getUrl(final String url,
3334
final List<String> contentFilter,
3435
final String sortFilter)
3536
throws ParsingException, UnsupportedOperationException {
36-
return url;
37+
return Utils.replaceHttpWithHttps(url);
3738
}
3839

3940
/**

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/linkHandler/BandcampStreamLinkHandlerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.schabi.newpipe.extractor.exceptions.ParsingException;
66
import org.schabi.newpipe.extractor.linkhandler.LinkHandlerFactory;
77
import org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper;
8+
import org.schabi.newpipe.extractor.utils.Utils;
89

910
import static org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper.BASE_URL;
1011

@@ -49,7 +50,7 @@ public String getUrl(final String input)
4950
if (input.matches("\\d+")) {
5051
return BASE_URL + "/?show=" + input;
5152
} else {
52-
return input;
53+
return Utils.replaceHttpWithHttps(input);
5354
}
5455
}
5556

0 commit comments

Comments
 (0)