feat(linter): remove all warnings

Author: glebec

.eslintrc.json

@@ -3,6 +3,7 @@
 	"parser": "babel-eslint",
 	"extends": "fullstack",
 	"rules": {
-		"semi": 0
+		"semi": 0,
+		"new-cap": [1, { "capIsNewExceptions": ["Router"] }]
 	}
 }

client/components/auth-form.js

@@ -13,19 +13,19 @@ const AuthForm = (props) => {
     <div>
       <form onSubmit={handleSubmit} name={name}>
         <div>
-          <label htmlFor='email'><small>Email</small></label>
-          <input name='email' type='text' />
+          <label htmlFor="email"><small>Email</small></label>
+          <input name="email" type="text" />
         </div>
         <div>
-          <label htmlFor='password'><small>Password</small></label>
-          <input name='password' type='password' />
+          <label htmlFor="password"><small>Password</small></label>
+          <input name="password" type="password" />
         </div>
         <div>
-          <button type='submit'>{displayName}</button>
+          <button type="submit">{displayName}</button>
         </div>
         {error && error.response && <div> {error.response.data} </div>}
       </form>
-      <a href='/auth/google'>{displayName} with Google</a>
+      <a href="/auth/google">{displayName} with Google</a>
     </div>
   )
 }

client/components/main.js

@@ -21,13 +21,13 @@ const Main = (props) => {
           isLoggedIn
             ? <div>
               {/* The navbar will show these links after you log in */}
-              <Link to='/home'>Home</Link>
-              <a href='#' onClick={handleClick}>Logout</a>
+              <Link to="/home">Home</Link>
+              <a href="#" onClick={handleClick}>Logout</a>
             </div>
             : <div>
               {/* The navbar will show these links before you log in */}
-              <Link to='/login'>Login</Link>
-              <Link to='/signup'>Sign Up</Link>
+              <Link to="/login">Login</Link>
+              <Link to="/signup">Sign Up</Link>
             </div>
         }
       </nav>

client/routes.js

@@ -23,13 +23,13 @@ class Routes extends Component {
         <Main>
           <Switch>
             {/* Routes placed here are available to all visitors */}
-            <Route path='/login' component={Login} />
-            <Route path='/signup' component={Signup} />
+            <Route path="/login" component={Login} />
+            <Route path="/signup" component={Signup} />
             {
               isLoggedIn &&
                 <Switch>
                   {/* Routes placed here are only available after logging in */}
-                  <Route path='/home' component={UserHome} />
+                  <Route path="/home" component={UserHome} />
                 </Switch>
             }
             {/* Displays our Login component as a fallback */}

client/store/user.js

@@ -41,7 +41,7 @@ export const auth = (email, password, method) =>
 export const logout = () =>
   dispatch =>
     axios.post('/auth/logout')
-      .then(res => {
+      .then(_ => {
         dispatch(removeUser())
         history.push('/login')
       })

server/auth/google.js

@@ -30,11 +30,11 @@ const strategy = new GoogleStrategy(googleConfig, (token, refreshToken, profile,
   const email = profile.emails[0].value
 
   User.find({where: {googleId}})
-    .then(user => user
-      ? done(null, user)
+    .then(foundUser => (foundUser
+      ? done(null, foundUser)
       : User.create({name, email, googleId})
-        .then(user => done(null, user))
-    )
+        .then(createdUser => done(null, createdUser))
+    ))
     .catch(done)
 })
 

server/auth/index.js

@@ -10,7 +10,7 @@ router.post('/login', (req, res, next) => {
       } else if (!user.correctPassword(req.body.password)) {
         res.status(401).send('Incorrect password')
       } else {
-        req.login(user, err => err ? next(err) : res.json(user))
+        req.login(user, err => (err ? next(err) : res.json(user)))
       }
     })
     .catch(next)
@@ -19,12 +19,14 @@ router.post('/login', (req, res, next) => {
 router.post('/signup', (req, res, next) => {
   User.create(req.body)
     .then(user => {
-      req.login(user, err => err ? next(err) : res.json(user))
+      req.login(user, err => (err ? next(err) : res.json(user)))
     })
     .catch(err => {
-      if (err.name === 'SequelizeUniqueConstraintError')
+      if (err.name === 'SequelizeUniqueConstraintError') {
         res.status(401).send('User already exists')
-      else next(err)
+      } else {
+        next(err)
+      }
     })
 })
 

server/db/models/user.js

@@ -36,7 +36,11 @@ User.generateSalt = function () {
 }
 
 User.encryptPassword = function (plainText, salt) {
-  return crypto.createHash('RSA-SHA256').update(plainText).update(salt).digest('hex')
+  return crypto
+    .createHash('RSA-SHA256')
+    .update(plainText)
+    .update(salt)
+    .digest('hex')
 }
 
 /**