fix(table-core): column getCanGroup always resolving to true (#4843)

mozzerbob · Phil Morris · KevinVandy · web-flow · commit fce4725f2df1 · 2024-03-29T00:18:01.000-05:00
* Fix getCanGroup always resolving to true

* fix column.getCanGroup

---------

Co-authored-by: Phil Morris &lt;phil@residently.com&gt;
Co-authored-by: Kevin Van Cott &lt;kevinvandy656@gmail.com&gt;
diff --git a/packages/table-core/src/features/ColumnGrouping.ts b/packages/table-core/src/features/ColumnGrouping.ts
@@ -283,11 +283,9 @@ export const ColumnGrouping: TableFeature = {
 
     column.getCanGroup = () => {
       return (
-        column.columnDef.enableGrouping ??
-        true ??
-        table.options.enableGrouping ??
-        true ??
-        !!column.accessorFn
+        (column.columnDef.enableGrouping ?? true) &&
+        (table.options.enableGrouping ?? true) &&
+        (!!column.accessorFn || !!column.columnDef.getGroupingValue)
       )
     }
 

Original file line number	Diff line number	Diff line change
`@@ -283,11 +283,9 @@ export const ColumnGrouping: TableFeature = {`
`283`	`283`
`284`	`284`	`column.getCanGroup = () => {`
`285`	`285`	`return (`
`286`		`- column.columnDef.enableGrouping ??`
`287`		`- true ??`
`288`		`- table.options.enableGrouping ??`
`289`		`- true ??`
`290`		`- !!column.accessorFn`
	`286`	`+ (column.columnDef.enableGrouping ?? true) &&`
	`287`	`+ (table.options.enableGrouping ?? true) &&`
	`288`	`+ (!!column.accessorFn \|\| !!column.columnDef.getGroupingValue)`
`291`	`289`	`)`
`292`	`290`	`}`
`293`	`291`