Skip to content

Commit 02b2493

Browse files
committed
refactor: mark observers as private
1 parent 4d85cf9 commit 02b2493

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/core/query.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ export class Query<TData = unknown, TError = unknown, TQueryFnData = TData> {
104104
queryHash: string
105105
options!: QueryOptions<TData, TError, TQueryFnData>
106106
defaultOptions?: QueryOptions<TData, TError, TQueryFnData>
107-
observers: QueryObserver<any, any, any, any>[]
108107
state: QueryState<TData, TError>
109108
cacheTime!: number
110109

@@ -114,6 +113,7 @@ export class Query<TData = unknown, TError = unknown, TQueryFnData = TData> {
114113
private cancelFetch?: (silent?: boolean) => void
115114
private continueFetch?: () => void
116115
private isTransportCancelable?: boolean
116+
private observers: QueryObserver<any, any, any, any>[]
117117

118118
constructor(config: QueryConfig<TData, TError, TQueryFnData>) {
119119
this.setOptions(config.options)
@@ -171,11 +171,7 @@ export class Query<TData = unknown, TError = unknown, TQueryFnData = TData> {
171171

172172
cancel(silent?: boolean): Promise<void> {
173173
const promise: Promise<any> = this.promise || Promise.resolve()
174-
175-
if (this.cancelFetch) {
176-
this.cancelFetch(silent)
177-
}
178-
174+
this.cancelFetch?.(silent)
179175
return promise.then(noop).catch(noop)
180176
}
181177

src/react/tests/suspense.test.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,13 @@ describe("useQuery's in Suspense mode", () => {
6767
fireEvent.click(rendered.getByLabelText('toggle'))
6868
await waitFor(() => rendered.getByText('rendered'))
6969

70+
// @ts-expect-error
7071
expect(cache.find(key)?.observers.length).toBe(1)
7172

7273
fireEvent.click(rendered.getByLabelText('toggle'))
7374

7475
expect(rendered.queryByText('rendered')).toBeNull()
76+
// @ts-expect-error
7577
expect(cache.find(key)?.observers.length).toBe(0)
7678
})
7779

0 commit comments

Comments
 (0)