fix: restore item_thumb delete action

Author: CyanVoxel

src/tagstudio/qt/ts_qt.py

@@ -1486,6 +1486,11 @@ def update_thumbs(self):
             )
             item_thumb.assign_badge(BadgeType.ARCHIVED, entry.id in tag_entries[TAG_ARCHIVED])
             item_thumb.assign_badge(BadgeType.FAVORITE, entry.id in tag_entries[TAG_FAVORITE])
+            item_thumb.delete_action.triggered.connect(
+                lambda checked=False, f=filenames[index], e_id=entry.id: self.delete_files_callback(
+                    f, e_id
+                )
+            )
 
             # Restore Selected Borders
             is_selected = item_thumb.item_id in self.selected

src/tagstudio/qt/widgets/item_thumb.py

@@ -4,12 +4,10 @@
 
 
 import time
-import typing
 from enum import Enum
 from functools import wraps
 from pathlib import Path
 from typing import TYPE_CHECKING, override
-from warnings import catch_warnings
 
 import structlog
 from PIL import Image, ImageQt
@@ -126,7 +124,7 @@ def __init__(
         self.lib = library
         self.mode: ItemType | None = mode
         self.driver = driver
-        self.item_id: int | None = None
+        self.item_id: int = -1
         self.thumb_size: tuple[int, int] = thumb_size
         self.show_filename_label: bool = show_filename_label
         self.label_height = 12
@@ -321,16 +319,16 @@ def __init__(
 
         self.base_layout.addWidget(self.thumb_container)
         self.base_layout.addWidget(self.file_label)
+        # NOTE: self.item_id seems to act as a reference here and does not need to be updated inside
+        # QtDriver.update_thumbs() while item_thumb.delete_action does.
+        # If this behavior ever changes, move this method back to QtDriver.update_thumbs().
         self.thumb_button.clicked.connect(
             lambda: self.driver.toggle_item_selection(
                 self.item_id,
                 append=(QGuiApplication.keyboardModifiers() == Qt.KeyboardModifier.ControlModifier),
                 bridge=(QGuiApplication.keyboardModifiers() == Qt.KeyboardModifier.ShiftModifier),
             )
         )
-        self.delete_action.triggered.connect(
-            lambda: self.driver.delete_files_callback(self.opener.filepath, self.item_id)
-        )
         self.set_mode(mode)
 
     @property
@@ -451,12 +449,6 @@ def update_size(self, timestamp: float, size: QSize):
             self.thumb_button.setMinimumSize(size)
             self.thumb_button.setMaximumSize(size)
 
-    def update_clickable(self, clickable: typing.Callable[[], None]):
-        """Updates attributes of a thumbnail element."""
-        with catch_warnings(record=True):
-            self.thumb_button.clicked.disconnect()
-        self.thumb_button.clicked.connect(clickable)
-
     def set_item_id(self, item_id: int):
         self.item_id = item_id