Add C++23 multi-argument operator[] as primary indexing interface #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require C++23 and remove deprecated comma-subscript warnings - Add variadic operator[] to basic_array and basic_array_view - Rename call<>() helper to subscript<>() for clarity - Make operator[] the primary implementation with operator() delegating to it - Update expression templates (expr, expr_unary) consistently - Add variadic operator[] to expr_call and array_adapter - Add comprehensive tests for the new subscript operator Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
operator[]syntax (e.g.,A[i, j, k]) as the primary indexing interfaceoperator()delegate tooperator[]for backward compatibilitybasic_array,basic_array_view,array_adapter,expr,expr_unary, andexpr_callChanges
cxx_std_23) and remove deprecated comma-subscript warningscall<>()helper tosubscript<>()for clarityoperator(): integers, ranges,range::all, ellipsis, and CLEF lazy placeholders all workTest plan
MultiDimensionalSubscriptOperatortest covers element access, CLEF, slicing, ellipsis, and expression templates