Fix Assembly property of UnavailableType

The assembly was the one in which the type was referenced
instead of the assembly containing the type.

Issue: #430
Signed-off-by: Jean-Philippe Durot <[email protected]>

Author: jpdurot

ArchUnitNET/Domain/UnavailableType.cs

@@ -47,20 +47,26 @@ private bool Equals(Struct other)
             return Equals(Type, other.Type);
         }
 
-        public override bool Equals(object obj)
+        public bool Equals(UnavailableType other)
         {
-            if (ReferenceEquals(null, obj))
+            if (ReferenceEquals(null, other))
             {
                 return false;
             }
 
-            if (ReferenceEquals(this, obj))
+            if (ReferenceEquals(this, other))
             {
                 return true;
             }
 
-            return obj.GetType() == GetType() && Equals((UnavailableType)obj);
+            return Type.Equals(other.Type);
         }
+        
+        public override bool Equals(object obj)
+        {
+            return obj is UnavailableType unavailableType
+                   && Equals(unavailableType);
+        } 
 
         public override int GetHashCode()
         {

ArchUnitNET/Loader/TypeFactory.cs

@@ -347,7 +347,7 @@ TypeReference typeReference
         )
         {
             var assemblyQualifiedName = System.Reflection.Assembly.CreateQualifiedName(
-                typeReference.Module.Assembly.FullName,
+                typeReference.Scope.Name,
                 typeReference.BuildFullName()
             );
             if (_allTypes.TryGetValue(assemblyQualifiedName, out var existingTypeInstance))
@@ -361,8 +361,8 @@ TypeReference typeReference
                         typeReference.BuildFullName(),
                         typeReference.Name,
                         _assemblyRegistry.GetOrCreateAssembly(
-                            typeReference.Module.Assembly.Name.Name,
-                            typeReference.Module.Assembly.FullName,
+                            typeReference.Scope.Name,
+                            typeReference.Scope.ToString(),
                             true,
                             null
                         ),

ArchUnitNETTests/Loader/ArchLoaderTests.cs

@@ -131,8 +131,8 @@ public void TypesAreAssignedToCorrectAssemblies()
         public void UnavailableTypeTest()
         {
             // When loading an assembly from a file, there are situations where the assemblies dependencies are not
-            // available in the current AppDomain. This test checks that the loader does not throw an exception in this
-            // case.
+            // available in the current AppDomain. This test checks that the loader does not throw an exception
+            // and that the unavailable types contain the correct assembly they come from.
             var currentAssemblyPath = AppDomain.CurrentDomain.BaseDirectory[
                 ..AppDomain.CurrentDomain.BaseDirectory.IndexOf(
                     @"ArchUnitNETTests",
@@ -153,6 +153,7 @@ public void UnavailableTypeTest()
             var loggerType = architecture.ReferencedTypes.WhereFullNameIs("Serilog.ILogger");
             Assert.NotNull(loggerType);
             Assert.True(loggerType is UnavailableType);
+            Assert.Equal("Serilog", loggerType.Assembly.Name);
         }
     }
 }