Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Setup github actions properly #125

Open
Tracked by #142
bnonni opened this issue Aug 29, 2024 · 5 comments
Open
Tracked by #142

Setup github actions properly #125

bnonni opened this issue Aug 29, 2024 · 5 comments
Assignees
Labels
cicd Related to devops in some way (github actions, docker, etc)) good first issue Good for newcomers hacktoberfest 2024 Related to hacktoberfest 2024 help wanted Extra attention is needed P2 priority level 2, important not urgent, schedule or delegate

Comments

@bnonni
Copy link
Contributor

bnonni commented Aug 29, 2024

Right now, the only github action runs on every push to all branches. It installs the dependencies, lints, builds and builds tests. We'd like to add

  • Run all tests
  • Upload coverage to codecov

Additionally, it would be ideal to have multiple flows:

  • non-main branch + prs into main
    • install, lint, build packages, build tests, run tests, upload coverage
  • main branch
    • install, lint, build packages, build tests, run tests, upload coverage, bump versions and publish to npmjs

If you have alternative ideas that make more sense, we are open to hearing those ideas.

@bnonni bnonni added good first issue Good for newcomers help wanted Extra attention is needed P2 priority level 2, important not urgent, schedule or delegate cicd Related to devops in some way (github actions, docker, etc)) hacktoberfest 2024 Related to hacktoberfest 2024 labels Aug 29, 2024
@aniketh-varma
Copy link

.take

@bnonni
Copy link
Contributor Author

bnonni commented Oct 9, 2024

Thanks @aniketh-varma! This issue has been assigned to you!

@bnonni
Copy link
Contributor Author

bnonni commented Oct 22, 2024

@aniketh-varma any updates here? Would love to see a PR! 😄

@aniketh-varma
Copy link

Hey @bnonni , apologies, I have been a bit busy lately. I am working on this issue and plan to raise a PR soon. Thanks!

@bnonni
Copy link
Contributor Author

bnonni commented Nov 1, 2024

@aniketh-varma no problem! Thanks for your help here. I know hacktoberfest is over, but I'd still welcome a PR and would be happy to collab with you on this issue. Just lmk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cicd Related to devops in some way (github actions, docker, etc)) good first issue Good for newcomers hacktoberfest 2024 Related to hacktoberfest 2024 help wanted Extra attention is needed P2 priority level 2, important not urgent, schedule or delegate
Projects
None yet
Development

No branches or pull requests

2 participants