code style fixes

Author: Syxton

db/upgrade.php

@@ -207,7 +207,7 @@ function xmldb_tool_coursearchiver_upgrade($oldversion) {
     // Update saves table to use json_encoding instead of serialize.
     if ($oldversion < 2025070102) {
         if ($saves = $DB->get_records('tool_coursearchiver_saves')) {
-            foreach($saves as $save) {
+            foreach ($saves as $save) {
                 $content = unserialize($save->content);
                 if (!empty($content)) {
                     $save->content = json_encode($content);

index.php

@@ -33,7 +33,7 @@
 admin_externalpage_setup('toolcoursearchiver');
 
 global $SESSION;
-$error      = isset($SESSION->coursearchiver_error) ? $SESSION->coursearchiver_error : optional_param('coursearchiver_error', false, PARAM_TEXT);
+$error      = $SESSION->coursearchiver_error ?? optional_param('coursearchiver_error', false, PARAM_TEXT);
 $error      = htmlspecialchars($error, ENT_COMPAT);
 
 $submitted  = optional_param('submitbutton', false, PARAM_TEXT);

step2.php

@@ -33,12 +33,12 @@
 admin_externalpage_setup('toolcoursearchiver');
 
 global $SESSION;
-$formdata   = isset($SESSION->coursearchiver_formdata) ? $SESSION->coursearchiver_formdata : optional_param('formdata', false, PARAM_TEXT);
+$formdata   = $SESSION->coursearchiver_formdata ?? optional_param('formdata', false, PARAM_TEXT);
 
-$error      = isset($SESSION->coursearchiver_error) ? $SESSION->coursearchiver_error : optional_param('coursearchiver_error', false, PARAM_TEXT);
+$error      = $SESSION->coursearchiver_error ?? optional_param('coursearchiver_error', false, PARAM_TEXT);
 $error      = htmlspecialchars($error, ENT_COMPAT);
 
-$resume     = isset($SESSION->coursearchiver_resume) ? $SESSION->coursearchiver_resume : optional_param('coursearchiver_resume', false, PARAM_TEXT);
+$resume     = $SESSION->coursearchiver_resume ?? optional_param('coursearchiver_resume', false, PARAM_TEXT);
 $resume     = htmlspecialchars($resume, ENT_COMPAT);
 
 $title      = optional_param('save_title', false, PARAM_TEXT);

step3.php

@@ -33,13 +33,13 @@
 admin_externalpage_setup('toolcoursearchiver');
 
 global $SESSION;
-$formdata   = isset($SESSION->coursearchiver_formdata) ? $SESSION->coursearchiver_formdata : optional_param('formdata', false, PARAM_TEXT);
-$mode       = isset($SESSION->coursearchiver_mode) ? $SESSION->coursearchiver_mode : optional_param('coursearchiver_mode', false, PARAM_INT);
+$formdata   = $SESSION->coursearchiver_formdata ?? optional_param('formdata', false, PARAM_TEXT);
+$mode       = $SESSION->coursearchiver_mode ?? optional_param('coursearchiver_mode', false, PARAM_INT);
 
-$error      = isset($SESSION->coursearchiver_error) ? $SESSION->coursearchiver_error : optional_param('coursearchiver_error', false, PARAM_TEXT);
+$error      = $SESSION->coursearchiver_error ?? optional_param('coursearchiver_error', false, PARAM_TEXT);
 $error      = htmlspecialchars($error, ENT_COMPAT);
 
-$resume     = isset($SESSION->coursearchiver_resume) ? $SESSION->coursearchiver_resume : optional_param('coursearchiver_resume', false, PARAM_TEXT);
+$resume     = $SESSION->coursearchiver_resume ?? optional_param('coursearchiver_resume', false, PARAM_TEXT);
 $resume     = htmlspecialchars($resume, ENT_COMPAT);
 
 $title      = optional_param('save_title', false, PARAM_TEXT);

step4.php

@@ -34,12 +34,12 @@
 admin_externalpage_setup('toolcoursearchiver');
 
 global $SESSION;
-$formdata   = isset($SESSION->coursearchiver_formdata) ? $SESSION->coursearchiver_formdata : optional_param('formdata', false, PARAM_TEXT);
+$formdata   = $SESSION->coursearchiver_formdata ?? optional_param('formdata', false, PARAM_TEXT);
 
-$error      = isset($SESSION->coursearchiver_error) ? $SESSION->coursearchiver_error : optional_param('coursearchiver_error', false, PARAM_TEXT);
+$error      = $SESSION->coursearchiver_error ?? optional_param('coursearchiver_error', false, PARAM_TEXT);
 $error      = htmlspecialchars($error, ENT_COMPAT);
 
-$mode       = isset($SESSION->coursearchiver_mode) ? $SESSION->coursearchiver_mode : optional_param('coursearchiver_mode', false, PARAM_INT);
+$mode       = $SESSION->coursearchiver_mode ?? optional_param('coursearchiver_mode', false, PARAM_INT);
 $folder     = optional_param('folder', false, PARAM_TEXT);
 
 $submitted  = optional_param('submit_button', false, PARAM_TEXT);