Trigger "partially_refund" order payment transition on each partial refund

[laurentdabbb]

Hi,

According to code lines below, "partially_refund" transition is not triggered on order payment state if that state is already on "partially_refund".

RefundPlugin/src/StateResolver/OrderPartiallyRefundedStateResolver.php

Lines 50 to 56 in 518ba6e

	if ($order->getPaymentState() === OrderPaymentStates::STATE_PARTIALLY_REFUNDED) {
	return;
	}
	$stateMachine = $this->stateMachineFactory->get($order, OrderPaymentTransitions::GRAPH);
	$stateMachine->apply(OrderPaymentTransitions::TRANSITION_PARTIALLY_REFUND);

I think it's a mistake.
sylius_order_payment state machine allow transition from "partially_refund" to "partially_refund". So why not playing transition on a new partial refund ?

Rather than checking current order payment state, you should use if( $stateMachine->can( OrderPaymentTransitions::TRANSITION_PARTIALLY_REFUND ) ) before applying.

What do you think about ?

Thanks a lot ;-)

[GSadee]

Hi @laurentdabbb, thank you for reporting the issue. If I see correctly, you may be right and in fact nothing stands in the way of triggering this transition, even if it does not change anything, because as a result we will be in the same state and there are no callbacks defined to it. Would you like to open a PR with such a change?