PayPayClient shouldn't be using channelContext under the hood

[diimpp]

PayPalPlugin/src/Client/PayPalClient.php

Line 118 in c1c5d45

'PayPal-Partner-Attribution-Id' => $this->payPalConfigurationProvider->getPartnerAttributionId($channel),

channelContext makes Client stateful and denies ability to select right Partner-Attribution-Id.

Additionally Partner-Attribution-Id seems optional, but asserted as required at Provider/PayPalConfigurationProvider->getPartnerAttributionId

Logic for getting GatewayConfig at Provider/PayPalConfigurationProvider doesn't look production ready as well.

[Zales0123]

Hi Dmitri! Thank you for your issues, they're very helpful :)

Regarding the usage of the channel context - yes, it makes the client stateful, but in the first version of the plugin, we decide to simplify some configuration and support only one PayPal payment method. I agree it's limiting, but thanks to the proper separation of responsibilities (e.g. PayPalConfigurationProvider service) is should be quite easy to customize this behaviour. And definitely, we will want to make it the proper way as fast as possible.

Nonetheless, Partner-Attribution-Id is always provided by our facilitator app, so it will always by the same 🖖

PayPal-Partner-Attribution-Id in theory is not required, but PayPal required it anyway during the acceptation process of the integration 💃